LibWeb/HTML: Resolve image decoding promises inside tasks #2229
+80
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corresponds to whatwg/html#10753 While I was here, I've also implemented the check for the current request changing, and reformatted the spec comments to match our style.
ADKaster
reviewed
Nov 8, 2024
| CurrentRequestCompletelyAvailable, | ||
| }; | ||
| ImageState image_state; | ||
| auto previous_state = current_request().state(); |
There was a problem hiding this comment.
This double event loop spin has always been truly puzzling. ... why do we need it?
| CurrentRequestBroken, | ||
| CurrentRequestCompletelyAvailable, | ||
| }; | ||
| ImageState image_state; |
There was a problem hiding this comment.
:/ not initialized at declaration.
| return !this->document().is_fully_active() || state == ImageRequest::State::Broken || state == ImageRequest::State::CompletelyAvailable; | ||
| })); | ||
| if (state != previous_state) { | ||
| image_state = ImageState::CurrentRequestChanged; |
There was a problem hiding this comment.
does the state of the current request changing really mean that the current request changed? What about ABA? Should we be storing the "Current request" and making sure the image element still has the same request instead?
There was a problem hiding this comment.
"or is mutated" 🤔 How do we detect that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to whatwg/html#10753
While I was here, I've also implemented the check for the current request changing, and reformatted the spec comments to match our style.