LibWeb: Fix some CSS nesting bugs #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we first parse a nested CSSStyleRule's selectors, we treat them as relative selectors and then patch them up with an `&` as needed. However, we weren't doing this when assigning the `cssText` attribute. So, let's do that! This gives us a couple of subtest passes. :^)
This fixes 1 subtest.
If a & simple selector is on a style rule with no parent style rule, then it behaves like :scope - but notably, :scope provides 1 specificity in the class category, but & is supposed to provide 0. To solve this, we stop replacing it directly, and just handle the & like any other simple selector. We know that if the selector engine ever sees one, it's equivalent to :scope, because the nested ones will have been replaced with :is() before that point. This gets us one more subtest pass. :^)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 extra subtest passes!