LibWebView+Services+UI: Move common utilities to LibWebView #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trflynn89
force-pushed
the
webview
branch
4 times, most recently
from
eee6f84
to
b7b53d9
Compare
We currently compile the Qt event loop files multiple times, for every target which wants to use them. This patch moves these to LibWebView as a central location to avoid this.
|
Hm. Is adding a dependency on the specific UI toolkit to LibWebView the right layer of abstraction? Does every user of the Qt EventLoop also need LibWebView? |
As of right now, yes. If for some reason, we add another Qt application that doesn't want a WebView, I figure we can add a LibUI or something at that point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of files that we recompile for each of the Ladybird, WebContent, WebWorker, WebDriver, ImageDecoder, and RequestServer targets. Each of these utilities (event loops, process helpers, etc.) can happily live in LibWebView, as all embedders of LibWebView will need these facilities anyways.
Remembered that this was a thing while working on #2251.