Skip to content

Commit

Permalink
Directly use xvfb-run instead of (flaky) setup-xvfb actions in github…
Browse files Browse the repository at this point in the history
… actions (#294)

* Try new xvfb action

* Test calling xvfb-run directly
  • Loading branch information
Laguna1989 authored Oct 14, 2023
1 parent 2533d33 commit 5ba49a0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 12 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,8 @@ jobs:
run: ninja -j 4 jt_performance

- name: Execute Performance Test
uses: GabrielBB/xvfb-action@v1
with:
working-directory: ${{github.workspace}}/test/integration/performance
run: ./jt_performance --benchmark_format=json --benchmark_out=benchmark_result.json
working-directory: ${{github.workspace}}/test/integration/performance
run: xvfb-run ./jt_performance --benchmark_format=json --benchmark_out=benchmark_result.json

- name: Store benchmark result
uses: benchmark-action/github-action-benchmark@v1
Expand Down
12 changes: 4 additions & 8 deletions .github/workflows/test_verification.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,8 @@ jobs:
run: jackd -d dummy &

- name: Test
uses: GabrielBB/xvfb-action@v1
with:
run: ./jt_tests --gtest_shuffle
working-directory: ${{github.workspace}}/build/test/unit/jt_test
run: xvfb-run ./jt_tests --gtest_shuffle
working-directory: ${{github.workspace}}/build/test/unit/jt_test

LinuxSDL:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -108,10 +106,8 @@ jobs:
run: ninja

- name: Test
uses: GabrielBB/xvfb-action@v1
with:
run: ./jt_tests
working-directory: ${{github.workspace}}/build/test/unit/jt_test
run: xvfb-run ./jt_tests
working-directory: ${{github.workspace}}/build/test/unit/jt_test

WindowsSFML:
runs-on: windows-2019
Expand Down

0 comments on commit 5ba49a0

Please sign in to comment.