Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move deadzone code #48

Open
gregk27 opened this issue Mar 5, 2020 · 1 comment
Open

Move deadzone code #48

gregk27 opened this issue Mar 5, 2020 · 1 comment
Assignees
@N-A-Brock
Labels
Problem Something isn't working
Milestone
Drivetrain

Comments

@gregk27
Copy link
Contributor

gregk27 commented Mar 5, 2020

Deadzone code is currently applied in the Drivetrain subsystem. This is not good, as it means that all drive functions (notably those in auto), are forced through it, reducing the ability for precise control. These statements should be moved to either DriveCommand or Tools.getAdaptedSpeed().

image
@gregk27 gregk27 added the Problem Something isn't working label Mar 5, 2020
@gregk27 gregk27 added this to the Drivetrain milestone Mar 5, 2020
@gregk27
Copy link
Contributor Author

gregk27 commented Mar 7, 2020

This has been removed in noah-auto, and will be closed when it is merged to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@N-A-Brock N-A-Brock

Labels
Problem Something isn't working
Projects
None yet
Milestone
Drivetrain
Development

No branches or pull requests
2 participants
@gregk27 @N-A-Brock