[lua, sql] HNM Kings Rework #6795
Conversation
|
Draft for now until #6794 is merged. Please let me know if I've forgotten anything as well, lots to review for these big guys. |
| @@ -14,7 +14,8 @@ mobskillObject.onMobSkillCheck = function(target, mob, skill) | |||
| end | |||
|
|
|||
| mobskillObject.onMobWeaponSkill = function(target, mob, skill) | |||
| local dmgmod = xi.mobskills.mobBreathMove(mob, target, skill, 0.25, 1.5, xi.element.WATER, 400) | |||
| -- TODO: Needs a flat bonus 100 damage added to breath | |||
There was a problem hiding this comment.
Made an adjustment for that if you want to see if that looks okay to you
scripts/effects/super_buff.lua
Outdated
| target:addMod(xi.mod.MEVA, power) | ||
| target:addMod(xi.mod.UDMGMAGIC, -500) | ||
| target:addMod(xi.mod.UDMGPHYS, -5000) | ||
| target:addMod(xi.mod.UDMGRANGE, -5000) |
There was a problem hiding this comment.
Also:
effect:addMod() removes the need to have to delete the mods in onEffectLoose
There was a problem hiding this comment.
I ended up reverting this change after double checking that, looking at captures of Nidhogg the existing stats seem accurate to me.
CriticalXI
force-pushed
the
nm_audit_kings
branch
from
724f7aa to
8749726
Compare
| (caster:getFamily() == 51 or | ||
| caster:getFamily() == 479) | ||
| then | ||
| dmg = 14 + caster:getMainLvl() * 30 |
There was a problem hiding this comment.
The mob check is unneeded here. we already checked that the caster isnt a pc, so its a mob.
Can you link to something for this numbers?
There was a problem hiding this comment.
Jimmayus's monster stats: https://docs.google.com/spreadsheets/d/1YBoveP-weMdidrirY-vPDzHyxbEI2ryECINlfCnFkLI
Under the behemoth mob family on the Monster ftps tab
| @@ -57,7 +75,7 @@ entity.onSpellPrecast = function(mob, spell) | |||
| spell:setFlag(xi.magic.spellFlag.HIT_ALL) | |||
| spell:setRadius(30) | |||
| spell:setAnimation(280) | |||
| spell:setMPCost(1) | |||
| spell:setMPCost(0) | |||
There was a problem hiding this comment.
Oh, sneaky...
Unrelated to this line, doesnt KB have a draw-in mechanic or something?
I'm sure it doesnt go into the tunnels
There was a problem hiding this comment.
It has one already on it from cocosolo's draw in rework. It has an arena that draws in if you try going into the tunnels.
| mob:setMobMod(xi.mobMod.ALLI_HATE, 30) -- 30 yalm distance | ||
| end | ||
|
|
||
| return entity |
There was a problem hiding this comment.
newline at the end of the file
| else | ||
| { | ||
| weaponDamage = static_cast<CBattleEntity*>(m_PBaseEntity)->GetMainWeaponDmg(); | ||
| } |
There was a problem hiding this comment.
I think this got mixed. You have an open PR for this
There was a problem hiding this comment.
I was going to rebase and take this PR out of draft after the PR to add that in is merged so it won't appear as a new adjustment on here once that's done.
|
Looking good. Good job |
CriticalXI
force-pushed
the
nm_audit_kings
branch
2 times, most recently
from
d1aeee7 to
7706cbd
Compare
CriticalXI
force-pushed
the
nm_audit_kings
branch
from
7706cbd to
53b8a4c
Compare
|
Sorry to interject like this and hope it is not rude or annoying. These drop adjustments are an improvement but differ from what I worked out. I spent hours working them out the best I could due to the significance of the kings. Not sure the best way to proceed on the difference. If you rather keep these I can PR mine another time. Just didn't want to write a lot breaking down how I arrived at what I did. If you do keep these, there is a copy paste mistake on the Adamantoise Egg, Behemoth Tongue and Wyrm Beard (100% instead of 24%) and Fafnir does not drop the Wyrm Beard. |
I affirm:
What does this pull request do?
Stats and mob skill adjusts are based off of Jimmayus's monster stats capture sheet
Behe/KB: https://www.youtube.com/watch?v=uEayfQTiaac
Adamantoise/Aspis: https://www.youtube.com/watch?v=-5nZcruW-3w
Steps to test these changes
Spawn each HNM and see that it reflects the changes listed