[로또 게임] 김지웅 2차 과제 제출합니다. #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
mvc에서 비즈니스 로직을 수행하는 역할은 controller가 합니다.
|
|
||
| import java.util.List; | ||
|
|
||
| public class LottoResultChecker { |
There was a problem hiding this comment.
객체라기보다는 함수를 실행시키는 역할만 하는 것으로 보이네요.
| private final Console console = System.console(); | ||
| private final Scanner scanner; | ||
|
|
||
| public LottoInput() { |
There was a problem hiding this comment.
이건 무슨 의도죠? console은 주어진 요구사항입니다. 굳이 예외처리 하지 않아도 됩니다.
| if (console != null) { | ||
| input = console.readLine(); | ||
| } else { | ||
| input = scanner.nextLine(); |
There was a problem hiding this comment.
굳이 왜 scanner 사용을 고집하는걸까요? 가독성이 떨어집니다.
| import java.util.List; | ||
|
|
||
| public class Application { | ||
| public static void main(String[] args) { |
There was a problem hiding this comment.
main 함수에 모든 흐름이 다적혀 있네요. controller는 단순히 실행시키는 역할을 하는 객체가 아닙니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.