Fix linux installation for newer Unity versions #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description ============ It seems a very old bug suddenly surfaced. The linux pkg install logic is reading the contents of the archive into memory and passing it down to the stdin for the `cpio` command. I used the singe `write` call to copy the `buffer` to the `stdin` without checking if all bytes are actually written. It seems pure luck that this worked until now. It seems that in recent versions of Unity some packages got so big that a single call to `write` wasn't writing all the bytes into the memory location. I replaced the logic with a filestream copy instead. Something I should have done to begin with ...
Larusso
force-pushed
the
fix/linux_pkg_installer
branch
from
c72fc1b
to
0528bfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems a very old bug suddenly surfaced.
The linux pkg install logic is reading the contents of the archive into memory and passing it down to the stdin for the
cpiocommand. I used the singewritecall to copy thebufferto thestdinwithout checking if all bytes are actually written. It seems pure luck that this worked until now. It seems that in recent versions of Unity some packages got so big that a single call towritewasn't writing all the bytes into the memory location.I replaced the logic with a filestream copy instead. Something I should have done to begin with ...