Fix wrong install location of WebGL component on linux #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joaquimmnetto
changed the title
Joaquimmnetto
changed the title
Larusso
approved these changes
Jun 26, 2024
|
Need to check the test setup. It now screams around :) |
|
Tests fixed. However had to format the fixture files to be able to check where should I change, so that inflated the change count a bunch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux installations, the webGL component ended up on a duplicated path(ex: `UnityRoot/Editor/Data/PlaybackEngines/WebGLSupport/Editor/Data/PlaybackEngines/WebGLSupport). This is due to the txz file with the component already having a folder structure on its own and assuming it will be unpackaged on Unity root.
This fixes the issue by letting the webGL base path be the unity root, and letting the txz folder structure unpack it in the right place.