#pragma once

Lawliet828 · Apr 28, 2024 · f2f7973 · f2f7973
1 parent 3e16e43
commit f2f7973
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/muduo/base/LogStream.cc b/muduo/base/LogStream.cc
@@ -42,6 +42,7 @@ static_assert(sizeof(digits) == 20, "wrong number of digits");
 const char digitsHex[] = "0123456789ABCDEF";
 static_assert(sizeof digitsHex == 17, "wrong number of digitsHex");
 
+// https://github.com/fmtlib/format-benchmark/blob/master/src/itoa-benchmark/mwilson.cpp
 // Efficient Integer to String Conversions, by Matthew Wilson.
 template<typename T>
 size_t convert(char buf[], T value)
@@ -205,13 +206,6 @@ std::string formatIEC(int64_t s)
 
 }  // namespace muduo
 
-template<int SIZE>
-const char* FixedBuffer<SIZE>::debugString()
-{
-  *cur_ = '\0';
-  return data_;
-}
-
 void LogStream::staticCheck()
 {
   static_assert(kMaxNumericSize - 10 > std::numeric_limits<double>::digits10,

diff --git a/muduo/base/LogStream.h b/muduo/base/LogStream.h
@@ -3,8 +3,7 @@
 //
 // Author: Shuo Chen (chenshuo at chenshuo dot com)
 
-#ifndef MUDUO_BASE_LOGSTREAM_H
-#define MUDUO_BASE_LOGSTREAM_H
+#pragma once
 
 #include <assert.h>
 #include <string.h>  // memcpy
@@ -48,7 +47,10 @@ class FixedBuffer : noncopyable {
   void bzero() { memZero(data_, sizeof data_); }
 
   // for used by GDB
-  const char* debugString();
+  const char* debugString() {
+    *cur_ = '\0';
+    return data_;
+  }
   // for used by unit test
   string toString() const { return string(data_, length()); }
   StringPiece toStringPiece() const { return StringPiece(data_, length()); }
@@ -172,5 +174,3 @@ string formatSI(int64_t n);
 string formatIEC(int64_t n);
 
 }  // namespace muduo
-
-#endif  // MUDUO_BASE_LOGSTREAM_H