contrib: add OP_RETURN message capability to signet miner #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelrogstad
force-pushed
the
2024-10-09-mining
branch
from
57c8bc8
to
4dbdd3e
Compare
|
I see now that it might make more sense to make the |
torkelrogstad
force-pushed
the
2024-10-09-mining
branch
from
4dbdd3e
to
edfaad8
Compare
|
Update: I've now changed this from being OP_RETURN based to instead taking in the raw vout. It was used to mine this block: https://mempool.drivechain.live/tx/4a12bc5fd6f97e9b7258ea99236b247accb1e95c635cf8693f02eafd1d2b52e1 |
|
@torkelrogstad If you rebase on master, CI should pass |
torkelrogstad
force-pushed
the
2024-10-09-mining
branch
from
edfaad8
to
81fee5e
Compare
|
CI did not pass :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
--op-return-voutargument to the miner. This can be passed multiple times. The argument expects a hex-encoded byte value. The decoded
bytesis added as anOP_RETURNoutput to the generated coinbase.Used to mine this block: https://mempool.drivechain.live/block/00000334053962788aef8d9a89c724cbf33deab8a5e58de4c36bf3b50ed2123e