Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a standard ERC20 token instead of our unsafe non-standard version #49

Open
samlaf opened this issue May 3, 2024 · 1 comment
Open

Comments

@samlaf
Copy link
Collaborator

samlaf commented May 3, 2024

Currently we use a weird forked erc20 mock token that doesn't check allowance in transferFrom, and also mints on transfer I believe, just so that tests are easier to write.
Given that inc-sq is becoming more serious with more eyes on it, we shouldn't be doing this and should follow proper standards.

Let's use a standard openzeppelin ERC20 token standard and fix our tests to mint and allow where needed. See discussion in https://github.com/Layr-Labs/incredible-squaring-avs/pull/48/files#r1585342637

@0xpanicError
Copy link

Can I take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants