Update dppx for iPhone 6 Plus / 6s Plus / 7 Plus #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to the reported value according to [Window.devicePixelRatio](https://developer.mozilla.org/en-US/docs/Web/API/Window/devicePixelRatio)
|
Fascinating. I'm really not sure what to do here, since depending on which definition we'd rather focus on, all these numbers could be considered correct. |
|
I explained it in this issue and also suggested a solution |
|
@LeaVerou Have you decided what direction to take? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to the reported value according to Window.devicePixelRatio.
This article does a terrific job of explaining all the details of how Apple scales the display resolution. The computed value of viewport to physical dimension is approximately 2.6087, but the virtual ratio is 3.0.