Encoding and user_id bug fixes LRN-43802 LRN-44754 LRN-44748 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-scarratt-lrn
changed the title
shtrom
reviewed
Aug 29, 2024
david-scarratt-lrn
force-pushed
the
LRN-43802/bug/signature-mismatch
branch
2 times, most recently
from
6d0d2d1
to
0a6afed
Compare
[TEST] Include user_id in api-events security packet LRN-44754
david-scarratt-lrn
force-pushed
the
LRN-43802/bug/signature-mismatch
branch
from
0a6afed
to
b2ef214
Compare
shtrom
reviewed
Aug 30, 2024
Comment on lines
-356
to
+359
| return '20739eed410d54a135e8cb3745628834886ab315bfc01693ce9acc0d14dc98bf'; | ||
| return 'fd236f3bc3e14bb291a222637fe86d71c3d4393ed7c51353a2f9a14b356fd605'; | ||
| case '02': | ||
| return '$02$5c3160dbb9ab4d01774b5c2fc3b01a35ce4f9709c84571c27dfe333d1ca9d349'; | ||
| return '$02$e319a1c9c3e0118d1e81188a650b054a765e072a2d90e4b422ecca2ae9589449'; |
There was a problem hiding this comment.
It would be worth propagating those changes to the test-suite of the other SDKs. They should be using the same payload/signature pairs.
Comment on lines
+455
to
456
| $eventsApiExpected = '{"security":{"consumer_key":"yis0TYCu7U9V4o7M","domain":"localhost","timestamp":"20140626-0528","user_id":"events-proctor","signature":"' | ||
| . $eventsApiSig . '"},"config":{"users":{"$ANONYMIZED_USER_ID_1":"64ccf06154cf4133624372459ebcccb8b2f8bd7458a73df681acef4e742e175c","$ANONYMIZED_USER_ID_2":"7fa4d6ef8926add8b6411123fce916367250a6a99f50ab8ec39c99d768377adb","$ANONYMIZED_USER_ID_3":"3d5b26843da9192319036b67f8c5cc26e1e1763811270ba164665d0027296952","$ANONYMIZED_USER_ID_4":"3b6ac78f60f3e3eb7a85cec8b48bdca0f590f959e0a87a9c4222898678bd50c8"}}}'; |
There was a problem hiding this comment.
Surprised that the signature doesn't change with despite a change of payload. Is it not covered by it?
| $params = ParamsFixture::getWorkingDataApiParams(true); | ||
| $params['security']['user_id'] = 'a-user-id'; | ||
| $params['v1Compat'] = false; | ||
| $params['expected'] = 'yis0TYCu7U9V4o7M_localhost_20140626-0528_a-user-id_{"limit":100}_get'; |
There was a problem hiding this comment.
It might be worth adding signature checks, too.
david-scarratt-lrn
changed the title
|
User Story :- https://learnosity.atlassian.net/browse/LRN-44748 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Feature
Bug
ChangeLog.md updated
Tests added
All testsuite passes
make distcompleted successfully