Lrn 44748/bug/implement generate signature does not match #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
klauste
approved these changes
Sep 30, 2024
tests/Fixtures/ParamsFixture.php
Outdated
| * @param bool $assoc If true, associative array will be returned | ||
| * @return array | ||
| */ | ||
| public static function getWorkingAuthorApiParamsWithEmptyJsonRequest(bool $assoc = false): array |
sreenivasa-murty-lrn
force-pushed
the
LRN-44748/Bug/implement-generate-signature-does-not-match
branch
from
294fec2
to
63f20d3
Compare
|
Fixed the signature mismatch issue. |
api-events should forward user_id LRN-44754 [TEST] Include user_id in api-events security packet LRN-44754 Assimilate user_id treatment to LP LRN-43802 LRN-44748 [DOC] Update change log [Bug] Add the action value to the signature array only we not empty LRN-44748 [Bug] Fix the empty request param by converting to object and array LRN-44748 [Feature] Implement the request to jsonstring in contructor LRN-44748 [Feature] Iteration-3 Implement for generate() method the request MUST be any array LRN-44748 [Feature] Iteration-3 Convert the string to json for telemetry enabled LRN-44748 Use a decodedRequestPacket variable for the doecded request, fix up function signatures Fix up function signatures Remove wrong comment [Feature] Remove the unwanted code LRN-44748 Re-use variable instead of calling function again Remove double empty check [Feature] Add test case for geneeratesignature() with empty array and empty object LRN-44748 [Feature] Add new testcase for request with empty lines LRN-44748 [Feature] Remove the un-used method LRN-44748
sreenivasa-murty-lrn
force-pushed
the
LRN-44748/Bug/implement-generate-signature-does-not-match
branch
from
63f20d3
to
30c083d
Compare
sreenivasa-murty-lrn
deleted the
LRN-44748/Bug/implement-generate-signature-does-not-match
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Feature
Bug
ChangeLog.md updated
Tests added
All testsuite passes
make distcompleted successfully