Refactoring and Stax UX revamp #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y_external_outputs functions
…using NBGL. If a transaction has only a single non-change output, then we can fit the "Amount", "To" and "Fees" fields in a single screen.
By caching the first few external outputs during output preprocessing, we can greatly simplify the handling of the swap-related code, and the simplified UX for a single external output. This also allows to move all the swap-related checks in a single function. Finally, by moving all the checks not related to user approval out of show_alerts and display_output, we can omit calling these functions at all during swaps.
… transaction flow on flex/stax
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| int sign_result = sign_transaction(dc, &st, internal_inputs); | ||
|
|
||
| if (!G_swap_state.called_from_swap) { | ||
| ui_post_processing_confirm_transaction(dc, sign_result); |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #270 +/- ##
===========================================
- Coverage 84.77% 84.73% -0.05%
===========================================
Files 17 17
Lines 2187 2181 -6
===========================================
- Hits 1854 1848 -6
Misses 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Various simplifications in the code to generate the ragger instructions.
…tead of waiting for the timeout
bigspider
force-pushed
the
revamp
branch
2 times, most recently
from
c4c5cf5
to
57964ee
Compare
… remaining flows to use 'accounts' instead of 'wallet policy'
tdejoigny-ledger
previously approved these changes
Jul 10, 2024
Minor adjustments needed in some tests as the page splitting changed.
|
tdejoigny-ledger
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a substantial refactoring of the signing flow, allowing to simplify the UX code and implement the new design guidelines for Stax/Flex, using the new standard NBGL use cases.
Incidentally, it also improves the signing performance by 1-2s on typical transactions (on Stax/Flex only).
The UX for the wallet policy registration is also reimplemented using NBGL, reducing the number of taps/swipes required. Simplified the language, switching from "wallet policy" to the more simple "account".
Unrelated to the other changes, also includes a fix for the formatting of certain OP_RETURN outputs (4b1f0e0).
Prepares the next release 2.2.4.
Closes: #265.