Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master to 2.3.0 release. #290

Closed
wants to merge 36 commits into from
Closed

Sync master to 2.3.0 release. #290

wants to merge 36 commits into from

Conversation

bigspider
Copy link
Collaborator

No description provided.

bigspider and others added 30 commits July 16, 2024 09:55
Fix sign_psbt_instruction_approve
The UX refactoring in version 2.2.2 introduced a bug where signing messages
with certain lengths would fail, as the app would ask the client about chunks
with an overflowing index.
Fix `signMessage` failing for messages of certain lengths
client_rs: bump bitcoin 0.32 and miniscript 12.2
Bump version to 2.3.0; upate CHANGELOG and ragger snapshots
Always return to main menu at the end of get_wallet_address
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Oct 7, 2024

Wiz Scan Summary

Scan Module Critical High Medium Low Info Total
IaC Misconfigurations 0 0 2 0 0 2
Sensitive Data 0 0 0 0 0 0
Secrets 0 0 0 0 0 0
Total 0 0 2 0 0 2

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@bigspider bigspider closed this Oct 7, 2024
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (f17c7fd) to head (c9144de).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   84.73%   84.76%   +0.03%     
==========================================
  Files          17       17              
  Lines        2181     2186       +5     
==========================================
+ Hits         1848     1853       +5     
  Misses        333      333              
Flag Coverage Δ
unittests 84.76% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants