Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error codes #297

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Add error codes #297

merged 9 commits into from
Oct 29, 2024

Conversation

bigspider
Copy link
Collaborator

@bigspider bigspider commented Oct 18, 2024

Adds error codes for register_wallet, sign_psbt and for swap-related checks.

Also improved the developer documentation.

Closes: #286

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (df405d4) to head (193ff56).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #297   +/-   ##
========================================
  Coverage    84.76%   84.76%           
========================================
  Files           17       17           
  Lines         2186     2186           
========================================
  Hits          1853     1853           
  Misses         333      333           
Flag Coverage Δ
unittests 84.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bigspider bigspider marked this pull request as ready for review October 21, 2024 15:29
doc/README.md Outdated Show resolved Hide resolved
src/boilerplate/dispatcher.h Show resolved Hide resolved
src/error_codes.h Outdated Show resolved Hide resolved
src/error_codes.h Outdated Show resolved Hide resolved
src/error_codes.h Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@bigspider bigspider merged commit f39ba24 into develop Oct 29, 2024
141 of 143 checks passed
@bigspider bigspider deleted the errorcodes branch October 29, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional specific error codes to distinguish failure conditions
3 participants