Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SonarCloud code analysis #300

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Remove SonarCloud code analysis #300

merged 1 commit into from
Oct 30, 2024

Conversation

bigspider
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (f39ba24) to head (d2280dd).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #300   +/-   ##
========================================
  Coverage    84.76%   84.76%           
========================================
  Files           17       17           
  Lines         2186     2186           
========================================
  Hits          1853     1853           
  Misses         333      333           
Flag Coverage Δ
unittests 84.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@bigspider bigspider changed the title Do not make PRs's CI fail based on SonarCloud report Remove SonarCloud code analysis Oct 29, 2024
@bigspider bigspider marked this pull request as ready for review October 29, 2024 16:19
@bigspider bigspider merged commit bc81ed0 into develop Oct 30, 2024
145 checks passed
@bigspider bigspider deleted the sonar-too-loud branch October 30, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants