Merge pull request #8187 from LedgerHQ/support/pin-deps-remaining-wor…

…kflows build: pin OS + dependency versions for non-PR/release workflows
LedgerHQ · Oct 24, 2024 · 0be5538 · 0be5538
2 parents de89b29 + e16860b
commit 0be5538
Show file tree

Hide file tree

Showing 13 changed files with 37 additions and 38 deletions.
diff --git a/.github/workflows/account-migration.yml b/.github/workflows/account-migration.yml
@@ -14,7 +14,7 @@ on:
 jobs:
   account_migration:
     name: "account-migration"
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: generate token
         id: generate-token

diff --git a/.github/workflows/bot-super-report-custom.yml b/.github/workflows/bot-super-report-custom.yml
@@ -17,7 +17,7 @@ permissions:
 
 jobs:
   main:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
       - name: Setup the toolchain

diff --git a/.github/workflows/bot-super-report.yml b/.github/workflows/bot-super-report.yml
@@ -9,7 +9,7 @@ permissions:
 
 jobs:
   main:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
       - name: Setup the toolchain

diff --git a/.github/workflows/generate-screenshots.yml b/.github/workflows/generate-screenshots.yml
@@ -77,11 +77,11 @@ jobs:
       - uses: LedgerHQ/ledger-live/tools/actions/composites/update-snapshots-desktop@develop
         id: update-snapshots
         with:
-          os: ubuntu-latest
+          os: ubuntu-22.04
 
   report-start:
     name: Report start
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     if: inputs.commentId != ''
     steps:
       - name: generate token
@@ -115,7 +115,7 @@ jobs:
     needs: ["generate-screenshots-linux", "report-start"]
     if: ${{ !cancelled() }}
     name: Report end
-    runs-on: "ubuntu-latest"
+    runs-on: ubuntu-22.04
     steps:
       - name: generate token
         id: generate-token

diff --git a/.github/workflows/regen-doc.yml b/.github/workflows/regen-doc.yml
@@ -28,7 +28,7 @@ permissions:
 
 jobs:
   regen-doc:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: generate token
         id: generate-token
@@ -118,7 +118,7 @@ jobs:
 
   report-start:
     name: Report start
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     if: inputs.commentId != ''
     steps:
       - name: generate token
@@ -153,7 +153,7 @@ jobs:
     name: Report end
     needs: [regen-doc, report-start]
     if: ${{ !cancelled() }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: generate token
         id: generate-token

diff --git a/.github/workflows/regen-pods.yml b/.github/workflows/regen-pods.yml
@@ -28,7 +28,7 @@ permissions:
 
 jobs:
   regen-pods:
-    runs-on: macos-latest
+    runs-on: macos-14
     name: "Regenerate Podfile"
     env:
       SKIP_BUNDLE_CHECK: 1
@@ -123,7 +123,7 @@ jobs:
 
   report-start:
     name: Report start
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     if: inputs.commentId != ''
     steps:
       - name: generate token
@@ -158,7 +158,7 @@ jobs:
     name: Report end
     needs: [regen-pods, report-start]
     if: ${{ !cancelled() }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: generate token
         id: generate-token

diff --git a/.github/workflows/renovate.yml b/.github/workflows/renovate.yml
@@ -9,7 +9,7 @@ on:
 
 jobs:
   renovate:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     env:
       LOG_LEVEL: debug
       npm_config_ignore_scripts: true

diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
@@ -5,7 +5,7 @@ on:
 
 jobs:
   stale:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/stale@v4
         with:

diff --git a/.github/workflows/test-bridge-pr.yml b/.github/workflows/test-bridge-pr.yml
@@ -14,7 +14,7 @@ jobs:
     outputs:
       is-affected: ${{ steps.affected.outputs.is-affected }}
       paths: ${{ steps.affected.outputs.paths }}
-    runs-on: [ubuntu-latest]
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
         with:
@@ -48,7 +48,7 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - ubuntu-latest
+          - ubuntu-22.04
 
     runs-on: ${{ matrix.os }}
     steps:
@@ -65,7 +65,7 @@ jobs:
       - name: Install node-gyp globally
         if: runner.os == 'Windows'
         run: |
-          pnpm add -g node-gyp
+          pnpm add -g node-gyp@3.8.0
       - name: Install dependencies
         run: pnpm i --filter="live-common..." --filter="ledger-live"
       - name: Build

diff --git a/.github/workflows/test-design-system-reusable.yml b/.github/workflows/test-design-system-reusable.yml
@@ -63,7 +63,7 @@ jobs:
         uses: actions/upload-artifact@v4
         if: failure()
         with:
-          name: react-ui-test-results-ubuntu-latest
+          name: react-ui-test-results-ubuntu
           path: |
             libs/ui/tests/react.spec.js-snapshots/
             libs/ui/test-results/
@@ -72,9 +72,9 @@ jobs:
         with:
           script: |
             const fs = require("fs");
-            fs.writeFileSync("summary-ui-ubuntu-latest.txt", "${{ steps.test-ui.outcome }}", "utf-8");
+            fs.writeFileSync("summary-ui-ubuntu.txt", "${{ steps.test-ui.outcome }}", "utf-8");
       - uses: actions/upload-artifact@v4
         if: ${{ !cancelled() }}
         with:
           name: outputs-test-ui
-          path: ${{ github.workspace }}/summary-ui-ubuntu-latest.txt
+          path: ${{ github.workspace }}/summary-ui-ubuntu.txt
diff --git a/.github/workflows/test-integration-pr.yml b/.github/workflows/test-integration-pr.yml
@@ -14,7 +14,7 @@ jobs:
     outputs:
       is-affected: ${{ steps.affected.outputs.is-affected }}
       paths: ${{ steps.affected.outputs.paths }}
-    runs-on: [ubuntu-latest]
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
         with:
@@ -48,9 +48,9 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - ubuntu-latest
-          - macos-latest
-          - windows-latest
+          - ubuntu-22.04
+          - macos-14
+          - windows-2022
 
     runs-on: ${{ matrix.os }}
     steps:
@@ -60,15 +60,15 @@ jobs:
         id: toolchain
         with:
           skip-turbo-cache: "false"
-          upgrade_npm: ${{ matrix.os == 'windows-latest' }}
+          upgrade_npm: ${{ matrix.os == 'windows-2022' }}
           accountId: ${{ secrets.AWS_ACCOUNT_ID_PROD }}
           roleName: ${{ secrets.AWS_CACHE_ROLE_NAME }}
           region: ${{ secrets.AWS_CACHE_REGION }}
           turbo-server-token: ${{ secrets.TURBOREPO_SERVER_TOKEN }}
       - name: Install node-gyp globally
         if: runner.os == 'Windows'
         run: |
-          pnpm add -g node-gyp
+          pnpm add -g node-gyp@3.8.0
       - name: Install dependencies
         run: pnpm i --filter="live-common..." --filter="ledger-live"
       - name: Build

diff --git a/.github/workflows/test-integration.yml b/.github/workflows/test-integration.yml
@@ -31,9 +31,9 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - ubuntu-latest
-          - macos-latest
-          - windows-latest
+          - ubuntu-22.04
+          - macos-14
+          - windows-2022
 
     runs-on: ${{ matrix.os }}
     steps:
@@ -46,15 +46,15 @@ jobs:
         id: toolchain
         with:
           skip-turbo-cache: "false"
-          upgrade_npm: ${{ matrix.os == 'windows-latest' }}
+          upgrade_npm: ${{ matrix.os == 'windows-2022' }}
           accountId: ${{ secrets.AWS_ACCOUNT_ID_PROD }}
           roleName: ${{ secrets.AWS_CACHE_ROLE_NAME }}
           region: ${{ secrets.AWS_CACHE_REGION }}
           turbo-server-token: ${{ secrets.TURBOREPO_SERVER_TOKEN }}
       - name: Install node-gyp globally
         if: runner.os == 'Windows'
         run: |
-          pnpm add -g node-gyp
+          pnpm add -g node-gyp@3.8.0
       - name: Install dependencies
         run: pnpm i --filter="live-common..." --filter="ledger-live"
       - name: Build

diff --git a/tools/actions/composites/update-snapshots-desktop/action.yml b/tools/actions/composites/update-snapshots-desktop/action.yml
@@ -9,22 +9,21 @@ runs:
   using: "composite"
   steps:
     - name: Update playwright snapshots [Linux => xvfb-run]
-      if: inputs.os == 'ubuntu-latest'
-      run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright:update-snapshots
-      shell: bash
-    - name: Update playwright snapshots
-      if: inputs.os != 'ubuntu-latest'
+      if: startsWith(inputs.os, 'ubuntu')
+        run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm desktop test:playwright:update-snapshots
+        shell: bash   - name: Update playwright snapshots
+      if: ${{ !startsWith(inputs.os, 'ubuntu') }}
       run: pnpm desktop test:playwright:update-snapshots
       shell: bash
     - name: status (Linux | macOS)
-      if: ${{ inputs.os != 'windows-latest' }}
+      if: ${{ !startsWith(inputs.os, 'windows') }}
       id: status
       run: |
         echo "status=$(git status --porcelain | wc -l)" >> $GITHUB_OUTPUT
       shell: bash
     - name: status (Windows)
       id: status-windows
-      if: ${{ inputs.os == 'windows-latest' }}
+      if: startsWith(inputs.os, 'windows')
       run: |
         $out = $(git status --porcelain | measure -l | Format-Wide | Out-String -Stream)
         $out = $out.Trim()