Skip to content

Commit

Permalink
Remove abritrary percent values from i18n texts
Browse files Browse the repository at this point in the history
Use simpler sentences and replace the ReplacementTransactionUnderpriced.description
with something closer to the GasLessThanEstimate.title error
  • Loading branch information
chabroA committed Oct 23, 2023
1 parent 2dd4c8e commit 0c09efd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions apps/ledger-live-desktop/static/i18n/en/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,11 @@
},
"speedUp": {
"title": "Speed Up",
"description": "Re-submit the transaction with a higher network fee.\n\nThe network fee must be at least 30% higher than the fee of the original transaction."
"description": "Re-submit the transaction with a higher network fee."
},
"cancel": {
"title": "Cancel",
"description": "Sending 0 {{ticker}} to your own address.\n\nThe network fee must be at least 30% higher than the fee of the original transaction."
"description": "Sending 0 {{ticker}} to your own address."
},
"steps": {
"method": {
Expand Down Expand Up @@ -4960,7 +4960,7 @@
"errors": {
"ReplacementTransactionUnderpriced": {
"title": "Replacement transaction underpriced",
"description": "The network fee must be at least 10% higher than the fee of the original transaction."
"description": "The network fee might be too low. Please increase"
},
"NoSuchAppOnProvider": {
"title": "The {{appName}} app cannot be found for your specific configuration.",
Expand Down
4 changes: 2 additions & 2 deletions apps/ledger-live-mobile/src/locales/en/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"errors": {
"ReplacementTransactionUnderpriced": {
"title": "Replacement transaction underpriced",
"description": "The network fee must be at least 10% higher than the fee of the original transaction."
"description": "The network fee might be too low. Please increase"
},
"countervaluesUnavailable": {
"title": "We're not able to provide a countervalue for this asset at the moment"
Expand Down Expand Up @@ -3579,7 +3579,7 @@
},
"cancel": {
"title": "Cancel",
"description": "Sending 0 {{ticker}} to your own address.\nTo ensure cancellation, the network fee is 30% higher than the fee of the transaction meant to be cancelled."
"description": "Sending 0 {{ticker}} to your own address."
},
"error": {
"notEnoughFundsToCancel": "Cancelling transaction is not available because you don't have enough funds on your account.",
Expand Down

0 comments on commit 0c09efd

Please sign in to comment.