Merge pull request #5200 from LedgerHQ/bugfix/placeholder-text-when-c…

…hanging-device-language-from-Settings 🐛 [BUGFIX] : Fix Placeholder for language in changeLanguagePrompt
LedgerHQ · Oct 26, 2023 · 63657e5 · 63657e5
2 parents 3dc4937 + e72ed60
commit 63657e5
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 9 deletions.
diff --git a/.changeset/eight-windows-hope.md b/.changeset/eight-windows-hope.md
@@ -0,0 +1,5 @@
+---
+"ledger-live-desktop": patch
+---
+
+Fix placeholder text when changing device language from Settings
diff --git a/...sktop/src/renderer/screens/settings/sections/General/ChangeDeviceLanguagePromptDrawer.tsx b/...sktop/src/renderer/screens/settings/sections/General/ChangeDeviceLanguagePromptDrawer.tsx
@@ -59,6 +59,14 @@ const ChangeDeviceLanguagePromptDrawer: React.FC<Props> = ({
     [onError, analyticsContext],
   );
 
+  const getTextToDisplay = (key: "description" | "title") =>
+    t(`deviceLocalization.changeDeviceLanguagePrompt.${key}`, {
+      deviceName,
+      language: t(
+        `deviceLocalization.languages.${Languages[currentLanguage].deviceSupport?.label}`,
+      ),
+    });
+
   return (
     <Flex
       flexDirection="column"
@@ -107,15 +115,8 @@ const ChangeDeviceLanguagePromptDrawer: React.FC<Props> = ({
             });
             setInstallingLanguage(true);
           }}
-          titleWording={t("deviceLocalization.changeDeviceLanguagePrompt.title", {
-            language: t(
-              `deviceLocalization.languages.${Languages[currentLanguage].deviceSupport?.label}`,
-            ),
-            deviceName,
-          })}
-          descriptionWording={t("deviceLocalization.changeDeviceLanguagePrompt.description", {
-            deviceName,
-          })}
+          titleWording={getTextToDisplay("title")}
+          descriptionWording={getTextToDisplay("description")}
         />
       )}
     </Flex>

diff --git a/...ktop/tests/specs/accounts/account.spec.ts-snapshots/ETH-deleteAccount-linux.png b/...ktop/tests/specs/accounts/account.spec.ts-snapshots/ETH-deleteAccount-linux.png
diff --git a/...ngs/localization.spec.ts-snapshots/settings-français-with-device-l10n-win32.png b/...ngs/localization.spec.ts-snapshots/settings-français-with-device-l10n-win32.png