From 76b5ab2776d382e46dda89ae22eb7a5af8505382 Mon Sep 17 00:00:00 2001 From: Lucas Werey Date: Thu, 17 Oct 2024 13:00:49 +0200 Subject: [PATCH] :triangular_flag_on_post:(lld): remove objkt ff --- .changeset/lovely-paws-greet.md | 7 ++ .../tezos/AccountBodyHeader/index.tsx | 70 ++----------------- .../static/i18n/en/app.json | 17 ++--- .../src/featureFlags/defaultFeatures.ts | 1 - .../packages/types-live/src/feature.ts | 2 - 5 files changed, 17 insertions(+), 80 deletions(-) create mode 100644 .changeset/lovely-paws-greet.md diff --git a/.changeset/lovely-paws-greet.md b/.changeset/lovely-paws-greet.md new file mode 100644 index 000000000000..ec44da080f23 --- /dev/null +++ b/.changeset/lovely-paws-greet.md @@ -0,0 +1,7 @@ +--- +"@ledgerhq/types-live": patch +"ledger-live-desktop": patch +"@ledgerhq/live-common": patch +--- + +Remove LLD objkt feature flag because we don't support the webview anymore diff --git a/apps/ledger-live-desktop/src/renderer/families/tezos/AccountBodyHeader/index.tsx b/apps/ledger-live-desktop/src/renderer/families/tezos/AccountBodyHeader/index.tsx index 5e7bcc651019..c3e0541ec915 100644 --- a/apps/ledger-live-desktop/src/renderer/families/tezos/AccountBodyHeader/index.tsx +++ b/apps/ledger-live-desktop/src/renderer/families/tezos/AccountBodyHeader/index.tsx @@ -1,73 +1,15 @@ -import React, { useCallback } from "react"; +import React from "react"; import Delegation from "../Delegation"; -import Box from "~/renderer/components/Box"; -import Card from "~/renderer/components/Box/Card"; -import { useTranslation } from "react-i18next"; -import { useHistory } from "react-router-dom"; -import Text from "~/renderer/components/Text"; -import styled from "styled-components"; import { SubAccount } from "@ledgerhq/types-live"; -import Label from "~/renderer/components/Label"; -import Button from "~/renderer/components/ButtonV3"; -import { FeatureToggle } from "@ledgerhq/live-common/featureFlags/index"; import { TezosAccount } from "@ledgerhq/live-common/families/tezos/types"; type Props = { account: TezosAccount | SubAccount; parentAccount: TezosAccount | undefined | null; }; -const Wrapper = styled(Box).attrs(() => ({ - p: 4, -}))` - border-radius: 4px; - justify-content: space-between; - align-items: center; -`; -const TableContainer = styled(Card)` - border-radius: 4px; - overflow: hidden; -`; -const AccountBodyHeader = ({ account, parentAccount }: Props) => { - const history = useHistory(); - const { t } = useTranslation(); - const onNFTClick = useCallback(() => { - const pathname = `/platform/objkt`; - history.push({ - pathname, - state: { - accountId: account.id, - }, - }); - }, [history, account.id]); - return ( - <> - - - - - - {t("tezos.objkt.card.title")} - - - - - - - - - - - - - - ); -}; + +const AccountBodyHeader = ({ account, parentAccount }: Props) => ( + +); + export default AccountBodyHeader; diff --git a/apps/ledger-live-desktop/static/i18n/en/app.json b/apps/ledger-live-desktop/static/i18n/en/app.json index 97aeb1abb99b..72ed9632599f 100644 --- a/apps/ledger-live-desktop/static/i18n/en/app.json +++ b/apps/ledger-live-desktop/static/i18n/en/app.json @@ -2256,10 +2256,10 @@ } }, "memoTag": { - "title": "Need a Tag/Memo?", - "description": "You might need a <0>Tag/Memo for receiving this asset from an exchange. You can use any combination of numbers like 1234.", - "learnMore": "Learn more about Tag/Memo" - } + "title": "Need a Tag/Memo?", + "description": "You might need a <0>Tag/Memo for receiving this asset from an exchange. You can use any combination of numbers like 1234.", + "learnMore": "Learn more about Tag/Memo" + } }, "send": { "title": "Send", @@ -2778,15 +2778,6 @@ } } }, - "tezos": { - "objkt": { - "card": { - "title": "NFT (Non Fungible Tokens) collection", - "description": "You can see you Tezos NFTs directly through Objkt inside Ledger Live.", - "cta": "See my NFTs on Objkt" - } - } - }, "bitcoin": { "inputSelected": "SELECTED", "toSpend": "Coins to spend", diff --git a/libs/ledger-live-common/src/featureFlags/defaultFeatures.ts b/libs/ledger-live-common/src/featureFlags/defaultFeatures.ts index 45c4c7dc3545..9c9afbffa236 100644 --- a/libs/ledger-live-common/src/featureFlags/defaultFeatures.ts +++ b/libs/ledger-live-common/src/featureFlags/defaultFeatures.ts @@ -89,7 +89,6 @@ export const DEFAULT_FEATURES: Features = { ...CURRENCY_DEFAULT_FEATURES, brazeLearn: DEFAULT_FEATURE, - objkt: DEFAULT_FEATURE, portfolioExchangeBanner: DEFAULT_FEATURE, postOnboardingAssetsTransfer: DEFAULT_FEATURE, counterValue: DEFAULT_FEATURE, diff --git a/libs/ledgerjs/packages/types-live/src/feature.ts b/libs/ledgerjs/packages/types-live/src/feature.ts index d14a3468e2d9..8e892d9cc3ab 100644 --- a/libs/ledgerjs/packages/types-live/src/feature.ts +++ b/libs/ledgerjs/packages/types-live/src/feature.ts @@ -156,7 +156,6 @@ export type Features = CurrencyFeatures & { swapWalletApiPartnerList: Feature_SwapWalletApiPartnerList; stakePrograms: Feature_StakePrograms; portfolioExchangeBanner: Feature_PortfolioExchangeBanner; - objkt: Feature_Objkt; editEvmTx: Feature_EditEvmTx; stakeAccountBanner: Feature_StakeAccountBanner; newsfeedPage: Feature_NewsfeedPage; @@ -535,7 +534,6 @@ export type Feature_PostOnboardingAssetsTransfer = DefaultFeature; export type Feature_PtxServiceCtaExchangeDrawer = DefaultFeature; export type Feature_PtxServiceCtaScreens = DefaultFeature; export type Feature_PortfolioExchangeBanner = DefaultFeature; -export type Feature_Objkt = DefaultFeature; export type Feature_BrazeLearn = DefaultFeature; export type Feature_PtxSwapMoonpayProvider = DefaultFeature; export type Feature_PtxSwapExodusProvider = DefaultFeature;