Skip to content

Commit

Permalink
Add changeset
Browse files Browse the repository at this point in the history
  • Loading branch information
@hakim-adamik
hakim-adamik committed Sep 27, 2023
1 parent 4ed2616 commit 7e8e176
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/short-sheep-think.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ledgerhq/live-common": patch
---

Remove old obsolete hack of tezos gas limit

2 comments on commit 7e8e176

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Bot] Testing with 'Nitrogen' ❌ 2 txs ($3.51) ⏲ 19.8s

❌ 1 specs have problems: Tezos

What is the bot and how does it work? Everything is documented here!

❌ 2 mutation errors 
necessary accounts resynced in 0.38ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'delegate unrevealed'
✔️ transaction 
DELEGATE 0 XTZ
TO tz1aRoaRhSpRYvFdyvgWLL6TGyRoGF51wDjM
with fees=0.00037
with gasLimit=200
with storageLimit=0
(estimatedFees 0.000744)
STATUS (783ms)
  amount: 0 XTZ
  estimated fees: 0.000744 XTZ
  total spent: 0.000744 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "0.000744",
+   "Fee": "0.000661 XTZ",
  }
(totally spent 3.3s – ends at 2023-09-27T16:02:45.546Z)

necessary accounts resynced in 0.32ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'send unrevealed'
→ TO Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
✔️ transaction 
SEND 0.837296 XTZ
TO tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF
with fees=0.000375
with gasLimit=201
with storageLimit=0
(estimatedFees 0.000749)
STATUS (849ms)
  amount: 0.837296 XTZ
  estimated fees: 0.000749 XTZ
  total spent: 0.838045 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "0.837296",
+   "Amount": "0.837296 XTZ",
  }
(totally spent 3.1s – ends at 2023-09-27T16:02:45.555Z)
⚠️ 2 spec hints
  • Spec Tezos:
    • mutations should define a test(): send unrevealed, send revealed, send max (non delegating), delegate unrevealed, delegate revealed, undelegate unrevealed, undelegate revealed
    • There are not enough accounts to cover all mutations. Please increase the account target to at least 8 accounts
Details of the 2 mutations

Spec Tezos (3)

Spec Tezos found 3 Tezos accounts (preload: 261ms). Will use TezosWallet 2.4.2 on nanoS 2.1.0
Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
necessary accounts resynced in 0.38ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'delegate unrevealed'
✔️ transaction 
DELEGATE 0 XTZ
TO tz1aRoaRhSpRYvFdyvgWLL6TGyRoGF51wDjM
with fees=0.00037
with gasLimit=200
with storageLimit=0
(estimatedFees 0.000744)
STATUS (783ms)
  amount: 0 XTZ
  estimated fees: 0.000744 XTZ
  total spent: 0.000744 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "0.000744",
+   "Fee": "0.000661 XTZ",
  }
(totally spent 3.3s – ends at 2023-09-27T16:02:45.562Z)
necessary accounts resynced in 0.32ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'send unrevealed'
→ TO Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
✔️ transaction 
SEND 0.837296 XTZ
TO tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF
with fees=0.000375
with gasLimit=201
with storageLimit=0
(estimatedFees 0.000749)
STATUS (849ms)
  amount: 0.837296 XTZ
  estimated fees: 0.000749 XTZ
  total spent: 0.838045 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "0.837296",
+   "Amount": "0.837296 XTZ",
  }
(totally spent 3.1s – ends at 2023-09-27T16:02:45.566Z)
Details of the 5 uncovered mutations

Spec Tezos (5)

  • send revealed: balance is too low (1)
  • send max (non delegating): balance is too low (1)
  • delegate revealed: balance is too low (1)
  • undelegate unrevealed: balance is too low (1)
  • undelegate revealed: balance is too low (1)
Portfolio ($3.51) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
Tezos (3) 150 ops , 5.35484 XTZ ($3.51) 👍 249 tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF 
Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
Performance ⏲ 19.8s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 261ms 4.1s 1.01ms 1632ms N/A N/A N/A N/A
Tezos (2) 261ms 4.1s 1.01ms 1632ms N/A N/A N/A N/A

What is the bot and how does it work? Everything is documented here!

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Bot] Testing with 'Nitrogen' ❌ 2 txs ($3.49) ⏲ 19.5s

❌ 1 specs have problems: Tezos

What is the bot and how does it work? Everything is documented here!

❌ 2 mutation errors 
necessary accounts resynced in 0.35ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'send max (non delegating)'
→ TO Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
✔️ transaction 
SEND MAX
TO tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn
with fees=0.000575
with gasLimit=701
with storageLimit=0
(estimatedFees 0.000949)
STATUS (707ms)
  amount: 3.678358 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 3.679307 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "3.678358",
+   "Amount": "3.678358 XTZ",
  }
(totally spent 3.1s – ends at 2023-09-28T05:26:31.510Z)

necessary accounts resynced in 0.34ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'send max (non delegating)'
→ TO Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
✔️ transaction 
SEND MAX
TO tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA
with fees=0.000575
with gasLimit=701
with storageLimit=257
(estimatedFees 0.000949)
STATUS (956ms)
  amount: 1.610341 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 1.61129 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "1.610341",
+   "Amount": "1.610341 XTZ",
  }
(totally spent 3.3s – ends at 2023-09-28T05:26:31.514Z)
⚠️ 2 spec hints
  • Spec Tezos:
    • mutations should define a test(): send unrevealed, send revealed, send max (non delegating), delegate unrevealed, delegate revealed, undelegate unrevealed, undelegate revealed
    • There are not enough accounts to cover all mutations. Please increase the account target to at least 8 accounts
Details of the 2 mutations

Spec Tezos (3)

Spec Tezos found 3 Tezos accounts (preload: 187ms). Will use TezosWallet 2.4.2 on nanoS 2.1.0
Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
necessary accounts resynced in 0.35ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'send max (non delegating)'
→ TO Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
✔️ transaction 
SEND MAX
TO tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn
with fees=0.000575
with gasLimit=701
with storageLimit=0
(estimatedFees 0.000949)
STATUS (707ms)
  amount: 3.678358 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 3.679307 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "3.678358",
+   "Amount": "3.678358 XTZ",
  }
(totally spent 3.1s – ends at 2023-09-28T05:26:31.520Z)
necessary accounts resynced in 0.34ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'send max (non delegating)'
→ TO Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
✔️ transaction 
SEND MAX
TO tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA
with fees=0.000575
with gasLimit=701
with storageLimit=257
(estimatedFees 0.000949)
STATUS (956ms)
  amount: 1.610341 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 1.61129 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "1.610341",
+   "Amount": "1.610341 XTZ",
  }
(totally spent 3.3s – ends at 2023-09-28T05:26:31.523Z)
Details of the 6 uncovered mutations

Spec Tezos (6)

  • send unrevealed: balance is too low (1)
  • send revealed: balance is too low (1)
  • delegate unrevealed: balance is too low (1)
  • delegate revealed: balance is too low (1)
  • undelegate unrevealed: balance is too low (1)
  • undelegate revealed: balance is too low (1)
Portfolio ($3.49) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
Tezos (3) 150 ops , 5.35484 XTZ ($3.49) 👍 249 tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF 
Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
Performance ⏲ 19.5s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 187ms 3.9s 1.00ms 1663ms N/A N/A N/A N/A
Tezos (2) 187ms 3.9s 1.00ms 1663ms N/A N/A N/A N/A

What is the bot and how does it work? Everything is documented here!

Please sign in to comment.