fix(swap): install Ethereum app if at least one evm family in the swa…

…p and not already present in the deps [LIVE-14666]
LedgerHQ · Oct 28, 2024 · d546208 · d546208
1 parent 77f01ea
commit d546208
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 9 deletions.
diff --git a/.changeset/tiny-cobras-refuse.md b/.changeset/tiny-cobras-refuse.md
@@ -0,0 +1,5 @@
+---
+"@ledgerhq/live-common": patch
+---
+
+fix(swap): install Ethereum app if at least one evm family in the swap and not already present in the deps
diff --git a/libs/ledger-live-common/src/hw/actions/startExchange.ts b/libs/ledger-live-common/src/hw/actions/startExchange.ts
@@ -123,7 +123,7 @@ export const createAction = (
         ? getMainAccount(exchange.toAccount, exchange.toParentAccount)
         : null;
 
-    const request: AppRequest = useMemo(() => {
+    const request = useMemo<AppRequest>(() => {
       if (isSwapDisableAppsInstall()) {
         return {
           appName: "Exchange",
@@ -135,16 +135,28 @@ export const createAction = (
           requireLatestFirmware,
         };
       } else {
+        const shouldAddEthApp =
+          (mainFromAccount.currency.family === "evm" || mainToAccount.currency.family === "evm") &&
+          mainFromAccount.currency.managerAppName !== "Ethereum" &&
+          mainToAccount.currency.managerAppName !== "Ethereum";
+        const dependencies: AppRequest["dependencies"] = [
+          {
+            account: mainFromAccount,
+          },
+          {
+            account: mainToAccount,
+          },
+        ];
+
+        if (shouldAddEthApp) {
+          dependencies.push({
+            appName: "Ethereum",
+          });
+        }
+
         return {
           appName: "Exchange",
-          dependencies: [
-            {
-              account: mainFromAccount,
-            },
-            {
-              account: mainToAccount,
-            },
-          ],
+          dependencies,
           requireLatestFirmware,
         };
       }