Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect the sdk version from root project #3951

Merged

Conversation

Ferossgp
Copy link
Contributor

@Ferossgp Ferossgp commented Jul 7, 2023

📝 Description

Make @ledgerhq/react-native-hid package agnostic of compile SDK. This allows other projects with a higher SDK to use the package. The change is implemented in a backward-compatible version, and thus should not introduce any breaking changes.

❓ Context

  • Impacted projects: @ledgerhq/react-native-hid

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
live-common-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 10:40am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jul 7, 2023 10:40am
react-ui-storybook ⬜️ Ignored (Inspect) Jul 7, 2023 10:40am

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

🦋 Changeset detected

Latest commit: d21f0bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ledgerhq/react-native-hid Minor
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 7, 2023

@Ferossgp is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added ledgerjs Has changes in the ledgerjs open source libs fork Pull request base branch comes from a fork. labels Jul 7, 2023
@ghost ghost requested a review from valpinkman July 20, 2023 13:53
@valpinkman valpinkman merged commit 9070611 into LedgerHQ:develop Aug 2, 2023
12 checks passed
@Ferossgp Ferossgp deleted the bugfix/respect-sdk-version-ledger-hid branch August 2, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork Pull request base branch comes from a fork. ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants