Support/extract dummy app server logic to page object #4006

ggilchrist-ledger · 2023-07-12T11:14:42Z

📝 Description

Move playwright live app test setup logic to LiveAppWebview page object to simplify test setup and teardown
'Discover' page object model just handles elements on the discover page now
Changed discover spec to liveapp-sdk to better reflect what it's testing
Updating screenshots and dependencies
Improved Earn test to be more relevant
Skipping flaky stability test

❓ Context

Impacted projects: ``
Linked resource(s): ``

✅ Checklist

Test coverage
Atomic delivery
No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

changeset-bot · 2023-07-12T11:14:46Z

⚠️ No Changeset found

Latest commit: b2b3a22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2023-07-12T11:14:49Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
live-common-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 17, 2023 11:35am

3 Ignored Deployments

Name	Status	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Jul 17, 2023 11:35am
native-ui-storybook	⬜️ Ignored (Inspect)	Jul 17, 2023 11:35am
react-ui-storybook	⬜️ Ignored (Inspect)	Jul 17, 2023 11:35am

ggilchrist-ledger · 2023-07-12T11:56:18Z

@ggilchrist-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux
✅ - generate-screenshots-mac
❌ - generate-screenshots-windows

ggilchrist-ledger · 2023-07-12T15:09:59Z

@ggilchrist-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-windows
✅ - generate-screenshots-mac
✅ - generate-screenshots-linux

apps/ledger-live-desktop/tests/specs/services/buy.smoke.spec.ts

apps/ledger-live-desktop/tests/specs/services/earn.smoke.spec.ts

lld, test, screenshot

ggilchrist-ledger · 2023-07-13T13:35:30Z

@ggilchrist-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-mac
✅ - generate-screenshots-windows
✅ - generate-screenshots-linux

ggilchrist-ledger · 2023-07-13T13:43:40Z

tools/actions/composites/setup-test-desktop/action.yml

@@ -77,5 +77,5 @@ runs:
    - name: Build Dummy Live SDK and Dummy Wallet API apps for testing
      if: ${{ !inputs.skip_builds }}
      run: |
-        pnpm test-utils dummy-apps:build
+        pnpm --filter="dummy-*" build


The filter wasn't working on windows unless I did this

lld, test, screenshot

ggilchrist-ledger · 2023-07-17T10:51:01Z

@ggilchrist-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-mac
✅ - generate-screenshots-windows
✅ - generate-screenshots-linux

ggilchrist-ledger · 2023-07-17T12:55:56Z

@ggilchrist-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux
✅ - generate-screenshots-mac
❌ - generate-screenshots-windows

github-actions bot assigned ggilchrist-ledger Jul 12, 2023

github-actions bot added desktop Has changes in LLD mobile Has changes in LLM tools Has changes in tools automation CI/CD stuff screenshots Screenshots have been updated labels Jul 12, 2023

ggilchrist-ledger force-pushed the support/extract-dummy-app-server-logic-to-page-object branch from aa60297 to c55fb50 Compare July 12, 2023 11:32

github-actions bot removed tools Has changes in tools automation CI/CD stuff labels Jul 12, 2023

vercel bot deployed to Preview – live-common-tools July 12, 2023 11:36 View deployment

vercel bot deployed to Preview – live-common-tools July 12, 2023 11:55 View deployment

ggilchrist-ledger marked this pull request as ready for review July 12, 2023 11:56

vercel bot deployed to Preview – live-common-tools July 12, 2023 12:15 View deployment

vercel bot deployed to Preview – live-common-tools July 12, 2023 12:20 View deployment

github-actions bot removed the mobile Has changes in LLM label Jul 12, 2023

vercel bot deployed to Preview – live-common-tools July 12, 2023 15:10 View deployment

vercel bot deployed to Preview – live-common-tools July 12, 2023 15:32 View deployment

ggilchrist-ledger requested a review from valpinkman July 12, 2023 15:34

vercel bot deployed to Preview – live-common-tools July 12, 2023 15:34 View deployment

vercel bot deployed to Preview – live-common-tools July 12, 2023 15:55 View deployment

vercel bot deployed to Preview – live-common-tools July 13, 2023 08:22 View deployment

ggilchrist-ledger force-pushed the support/extract-dummy-app-server-logic-to-page-object branch from 6087379 to 7a3f554 Compare July 13, 2023 08:24

vercel bot deployed to Preview – live-common-tools July 13, 2023 08:28 View deployment

ggilchrist-ledger force-pushed the support/extract-dummy-app-server-logic-to-page-object branch from 7a3f554 to 437b7c3 Compare July 13, 2023 09:02

vercel bot deployed to Preview – live-common-tools July 13, 2023 09:03 View deployment

valpinkman requested changes Jul 13, 2023

View reviewed changes

live-github-bot bot and others added 2 commits July 13, 2023 12:19

test(lld): update screenshots (ubuntu-latest)

d4f49f7

lld, test, screenshot

test: changing dummy filter to see if it fixes windows runs

2e500b0

ggilchrist-ledger requested a review from a team July 13, 2023 12:25

github-actions bot added the tools Has changes in tools label Jul 13, 2023

vercel bot deployed to Preview – live-common-tools July 13, 2023 12:29 View deployment

test(lld): update screenshots (windows-latest)

76e5bf4

lld, test, screenshot

vercel bot deployed to Preview – live-common-tools July 13, 2023 12:34 View deployment

chore: adding console warn for service tests where server fails to start

6c4e593

vercel bot deployed to Preview – live-common-tools July 13, 2023 13:29 View deployment

chore: adding check for server running before trying to shut it down

fa2d0ac

vercel bot deployed to Preview – live-common-tools July 13, 2023 13:32 View deployment

ggilchrist-ledger commented Jul 13, 2023

View reviewed changes

test(lld): update screenshots (windows-latest)

ecf80d3

lld, test, screenshot

vercel bot deployed to Preview – live-common-tools July 13, 2023 14:14 View deployment

chore: remove redundant buy screenshots

b2b3a22

vercel bot deployed to Preview – live-common-tools July 13, 2023 14:17 View deployment

vercel bot deployed to Preview – live-common-tools July 17, 2023 09:17 View deployment

vercel bot deployed to Preview – live-common-tools July 17, 2023 10:49 View deployment

vercel bot deployed to Preview – live-common-tools July 17, 2023 11:11 View deployment

vercel bot deployed to Preview – live-common-tools July 17, 2023 11:16 View deployment

vercel bot deployed to Preview – live-common-tools July 17, 2023 11:30 View deployment

vercel bot deployed to Preview – live-common-tools July 17, 2023 11:33 View deployment

ggilchrist-ledger force-pushed the support/extract-dummy-app-server-logic-to-page-object branch from d03e12c to b2b3a22 Compare July 17, 2023 12:40

ggilchrist-ledger requested a review from valpinkman July 17, 2023 15:53

valpinkman approved these changes Jul 18, 2023

View reviewed changes

ggilchrist-ledger merged commit 3c68a17 into develop Jul 18, 2023
54 of 56 checks passed

ggilchrist-ledger deleted the support/extract-dummy-app-server-logic-to-page-object branch July 18, 2023 08:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support/extract dummy app server logic to page object #4006

Support/extract dummy app server logic to page object #4006

ggilchrist-ledger commented Jul 12, 2023 •

edited

Loading

changeset-bot bot commented Jul 12, 2023 •

edited

Loading

vercel bot commented Jul 12, 2023 •

edited

Loading

ggilchrist-ledger commented Jul 12, 2023 •

edited by live-github-bot bot

Loading

ggilchrist-ledger commented Jul 12, 2023 •

edited by live-github-bot bot

Loading

ggilchrist-ledger commented Jul 13, 2023 •

edited by live-github-bot bot

Loading

ggilchrist-ledger Jul 13, 2023

ggilchrist-ledger commented Jul 17, 2023 •

edited by live-github-bot bot

Loading

ggilchrist-ledger commented Jul 17, 2023 •

edited by live-github-bot bot

Loading

Support/extract dummy app server logic to page object #4006

Support/extract dummy app server logic to page object #4006

Conversation

ggilchrist-ledger commented Jul 12, 2023 • edited Loading

📝 Description

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

changeset-bot bot commented Jul 12, 2023 • edited Loading

⚠️ No Changeset found

vercel bot commented Jul 12, 2023 • edited Loading

ggilchrist-ledger commented Jul 12, 2023 • edited by live-github-bot bot Loading

ggilchrist-ledger commented Jul 12, 2023 • edited by live-github-bot bot Loading

ggilchrist-ledger commented Jul 13, 2023 • edited by live-github-bot bot Loading

ggilchrist-ledger Jul 13, 2023

Choose a reason for hiding this comment

ggilchrist-ledger commented Jul 17, 2023 • edited by live-github-bot bot Loading

ggilchrist-ledger commented Jul 17, 2023 • edited by live-github-bot bot Loading

ggilchrist-ledger commented Jul 12, 2023 •

edited

Loading

changeset-bot bot commented Jul 12, 2023 •

edited

Loading

vercel bot commented Jul 12, 2023 •

edited

Loading

ggilchrist-ledger commented Jul 12, 2023 •

edited by live-github-bot bot

Loading

ggilchrist-ledger commented Jul 12, 2023 •

edited by live-github-bot bot

Loading

ggilchrist-ledger commented Jul 13, 2023 •

edited by live-github-bot bot

Loading

ggilchrist-ledger commented Jul 17, 2023 •

edited by live-github-bot bot

Loading

ggilchrist-ledger commented Jul 17, 2023 •

edited by live-github-bot bot

Loading