Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/lld/fix eth stake track #4072

Closed
wants to merge 2 commits into from
Closed

Conversation

sarneijim
Copy link
Contributor

πŸ“ Description

No analytics in mixpanel and segment.
"page" attribute is a non supportable by segment

❓ Context

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@live-github-bot
Copy link
Contributor

❌ @sarneijim

Unfortunately this PR does not comply with the Contributing Conventions and will be closed automatically.

Feel free to reopen this PR once you have browsed through the guidelines.


Found Issues:

  • the branch name fix/lld/fix-eth-stake-track is invalid

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

πŸ¦‹ Changeset detected

Latest commit: a1e4816

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@live-github-bot live-github-bot bot closed this Jul 19, 2023
@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
live-common-tools βœ… Ready (Inspect) Visit Preview Jul 19, 2023 5:05pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 19, 2023 5:05pm
native-ui-storybook ⬜️ Ignored (Inspect) Jul 19, 2023 5:05pm
react-ui-storybook ⬜️ Ignored (Inspect) Jul 19, 2023 5:05pm

@github-actions github-actions bot added the desktop Has changes in LLD label Jul 19, 2023
@sarneijim sarneijim requested review from kallen-ledger and a team July 19, 2023 17:06
@sarneijim sarneijim deleted the fix/lld/fix-eth-stake-track branch August 4, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant