Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/lld/fix eth stake track #4073

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

sarneijim
Copy link
Contributor

πŸ“ Description

No analytics in mixpanel and segment.
"page" attribute is a non supportable by segment

❓ Context

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

πŸ¦‹ Changeset detected

Latest commit: a1e4816

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sarneijim sarneijim marked this pull request as ready for review July 19, 2023 17:07
@sarneijim sarneijim requested a review from a team as a code owner July 19, 2023 17:07
@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
live-common-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 19, 2023 5:07pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 19, 2023 5:07pm
native-ui-storybook ⬜️ Ignored (Inspect) Jul 19, 2023 5:07pm
react-ui-storybook ⬜️ Ignored (Inspect) Jul 19, 2023 5:07pm

@github-actions github-actions bot added the desktop Has changes in LLD label Jul 19, 2023
@sarneijim sarneijim requested a review from a team July 19, 2023 17:07
@sarneijim sarneijim merged commit 1eb3d3a into develop Jul 20, 2023
44 of 46 checks passed
@sarneijim sarneijim deleted the bugfix/lld/fix-eth-stake-track branch July 20, 2023 06:53
ghost pushed a commit that referenced this pull request Jul 21, 2023
* fix: fix Lido/Kiln button analytics not working

* chore: add changeset
ghost pushed a commit that referenced this pull request Jul 21, 2023
* feat(ledgerjs-cal): update CAL (#3984)

* Feat/llm/add staking_completed track llm DOT & XTZ (#3963)

* feat: add cosmos currency to page track

* feat: add sol currency to page track

* feat: add xtz currency to page track

* feat: add near currency to page track

* feat: add dot currency to page track

* feat: add celo currency to page track

* feat: add egld currency to page track

* chore: changeset

* fix: fix xtz comment

* feat: add stake_completed track to tezos llm

* feat: add stake_completed track to dot llm

* chore: add changeset

* fix: add flow to other staking_completed llm tracks

* fix: fix typecheck

* [FEAT][LIVE-7406] create evm send flow (LLD) (#3704)

Co-authored-by: 0xkvn <44363395+lambertkevin@users.noreply.github.com>
Co-authored-by: Landry Monga <lvndry@protonmail.com>

* Account deletion tests (#3975)

* test(lld): account deletion tests

* test(lld): update screenshots (macos-latest)

lld, test, screenshot

* test(lld): update screenshots (ubuntu-latest)

lld, test, screenshot

* test(lld): update screenshots (windows-latest)

lld, test, screenshot

---------

Co-authored-by: live-github-bot[bot] <105061298+live-github-bot[bot]@users.noreply.github.com>

* ci(llm): use proper release env for android

* tagged smoke tests

* chore: prepare test-desktop for smoke tests

* chore: add new smoke and all scripts for playwright

* test(lld): update screenshots (ubuntu-latest)

lld, test, screenshot

* test(lld): update screenshots (macos-latest)

lld, test, screenshot

* chore: update workflow + slack report

* test(lld): update screenshots (windows-latest)

lld, test, screenshot

* chore: format slack message

* chore: remove extra code

* ci(lld): test-desktop-external catch up

* chore: add github actor name in report

* ci(lld): restore slack reporting guards

* chore: update pnpm to 8.6 everywhere

* ci(desktop-external): clean up extra jobs

* test(lld): update screenshots (macos-latest)

lld, test, screenshot

* test(lld): update screenshots (ubuntu-latest)

lld, test, screenshot

* test(lld): update screenshots (windows-latest)

lld, test, screenshot

* chore: fix `if` statement in test desktop

* Feat/llm/remove swap refresh rates (#4003)

* feat: remove extra refresh effect when configuration change in swap llm

* chore: add changeset

* Fix translation keys issue in LLM in the Quick Actions section (#4002)

* Support LIVE-8118 rename optimism (#3964)

* fix: rename optimism

* fix: crypto assets search keys

* fix: update changeset

* fix: update env description

* fix: update cryptoassets list

* chore: fix broken JS in test-desktop for slack message

* test: added framework and test for wallet api/live app detox test

* test: made server.close function wait for  server onclose event to fire to prevent open handles

* test: improved non-android console warnings

* test: fixed ReactNativeWebView typing

* docs: mention useE2EInjection hook in README

* chore: updating desktop docs

* test: updated docs

* fix: remove dup logic

* chore: update readme and skipping test

* feat: created new test-utils directory to contain dummy live apps

* feat: created new test-utils directory to contain dummy live apps

* feat: adding dummy build to workflows

* chore: adding gitignore for dummy builds

* fix: continue test logic

* chore: dev dependency update

* chore: removed redundant scripts from dummy live apps

* chore: making test utils a dev dependency

* chore: update pnpmlock

* fix: downgrade ts/jest packages to lower version to see if it fixes detox issues

* chore: updated dummy server types

* chore: adding types to server start

* Rollback `evm-tools` jest config to pre v29 format

* chore: updating pnpmlock

* chore: updating pnpm filters and documentation for dummy apps

* chore: updating pnpm lock

* chore: fix lockfile

* Update README.md

* test: llm portfolio read only test

* chore: update pnpm-lock file

* chore: fix lint

* chore: implement review suggestions

* fix(LIVE-8530): quotes are not readable in light mode

* fix(LIVE-8530): added changset

* ci: fix concurrency when pushing on dev

* fix(deps): update dependency @abandonware/noble to v1.9.2-21

* feat: add discreet mode param to earn dashboard

* feat(PROTECT-1782): Change the wording around login to recover app

* feat(PROTECT-2171): change wording on recover login CTA

* chore: upgrade babel/core to latest

* chore: fix input checkout in workflows

* chore: add missing ref to test-desktop

* test: update detox and fix animation issues

* fix(LIVE-8530): use colors by color key by default

* Feat/llm/Implement and harmonise tracking for the entry point of each staking flow (#4016)

* feat: add celo currency to screen track

* feat:  cosmos currency to screen track

* feat:  elrond currency to screen track

* feat: near currency to screen track

* feat: polkadot currency to screen track

* feat: solana currency to screen track

* feat: tezos currency to screen track

* feat: algorand currency to screen track

* feat: algorand currency to screen page

* chore: add changeset

* chore: remove debugger

* chore: fix typescript

* chore: add test full suite command to github bot

* [LIVE-7547] Feature - Add telos evm to currencies (#4021)

* chore(deps): update dependency stream-json to v1.7.5

* chore: add command to bot

* chore: change input type in bot

* chore(bot): remove extra input in command

* [SUPPORT] remove unnecessary check on tx networkInfo (#4020)

* chore(actions): add new s3 cache action for turborepo

* ci(s3 cache): use custom s3 caching action with turbo

* chore: remove errors only

* chore(deps): update dependency @types/react-motion to ^0.0.34

* chore(deps): update dependency @react-native-async-storage/async-storage to v1.17.12

* [LIVE-7949] Design polishes for the new firmware update UX (#3792)

* feat(Firmware Update LLM): minor design and wording polishes

* feat(Firmware Update LLM): fix a few wordings and design feedback

* feat(Firmware Update LLM): minor spacing tweaks on the update drawers

* chore(Firmware Update LLM): add changelog

* feat(FirmwareUpdateLLM): add allowmanager lottie on apps backup and minor alignments

* feat(FirmwareUpdateLLM): final minor UI adjustments

* chore(NativeUILibrary): add changelog

* feat: created new test-utils directory to contain dummy live apps

chore: dev dependency update

chore: update pnpmlock

chore: updated dummy server types

* feat: added live app webview page object model

* test: buy/sell test working

* chore: updating liveapp-sdk spec to smoke

* chore: removing redundant screenshots and dep imports

test(lld): update screenshots (macos-latest)

lld, test, screenshot

test(lld): update screenshots (ubuntu-latest)

lld, test, screenshot

* test: improved earn test and skipping stability test

test(lld): update screenshots (ubuntu-latest)

lld, test, screenshot

test(lld): update screenshots (macos-latest)

lld, test, screenshot

test(lld): update screenshots (windows-latest)

lld, test, screenshot

* test: added type for webview

* test: changing dummy filter to see if it fixes windows runs

* test(lld): update screenshots (macos-latest)

lld, test, screenshot

* test(lld): update screenshots (ubuntu-latest)

lld, test, screenshot

* test: changing dummy filter to see if it fixes windows runs

* test(lld): update screenshots (windows-latest)

lld, test, screenshot

* chore: adding console warn for service tests where server fails to start

* chore: adding check for server running before trying to shut it down

* test(lld): update screenshots (windows-latest)

lld, test, screenshot

* chore: remove redundant buy screenshots

* Fix USDC Market Price Component Data (#4048)

* Fix USDC Market Price component data

* Typos

* chore: fix windows git crashing on generate screenshots

* feat: add feature flag to hide or show ptx services in LLM

* fix: update docs on feature flags

* chore: add changeset

* fix: remove unused imports

* fix: update dependency in useAssetAction

* fix: add override on feature flags for e2e test

* [LIVE-6263] Feature - Ledger infrastructure abstraction for the EVM Family (#3827)

Co-authored-by: Alexandre Chabrolin <9203826+chabroA@users.noreply.github.com>

* [support] Minor code improvements on the Celo integration (#3919)

Co-authored-by: Alexandre Chabrolin <9203826+chabroA@users.noreply.github.com>

* test: added test and  elements for market

* test: deleted an unnecessary comment in marketPage.ts

* renaming fonctions and testID and removing async in marketPage.ts

* changes done according to feedbacks on the pr. Wildcard added for the url.

* comments deleted, unusual await deleted, refacto of the url expect assert

* fix made following the raised points

* fix: using previous testID for search bar

* test: adding buy button testid in after rebase

* [LIVE-7445] Filter device selection to only stax when using NFT as CLS (#3999)

* fix(CLS): filter for stax devices when using new device selection screen

* fix(CLS): fix import order

* chore(CLS): add changelog

* feat(CLS LLM): add model id filter to bluetooth pairing flow

* test: added tests for no available swap providers

* chore: improving live sdk warning message

* fix: updated wait in swap page navigate

* feat: logging video path to make it easier to identify a pw video with a test

* chore: added line break to make log more readable

* test: added @smoke tag to tests, removed screenshots for regeneration and renamed files

test(lld): update screenshots (macos-latest)  lld, test, screenshot

test(lld): update screenshots (ubuntu-latest)  lld, test, screenshot

test(lld): update screenshots (windows-latest)  lld, test, screenshot

test: added @smoke tag to manual syncOnboarding

test(lld): update screenshots (macos-latest)  lld, test, screenshot

test(lld): update screenshots (ubuntu-latest)  lld, test, screenshot

test(lld): update screenshots (windows-latest)  lld, test, screenshot

chore: trigger ci

* Bugfix/lld/fix eth stake track (#4073)

* fix: fix Lido/Kiln button analytics not working

* chore: add changeset

* feat(LIVE-6958): package script update

rename shared-ui to ui-shared

* feat(LIVE-6958): add provider icon sizes & cdn url to LLC

feat(LIVE-6958): use new provider icon component from desktop

feat(LIVE-6958): use new provider icon component from mobile

* feat(LIVE-6958): add changeset

* feat(LIVE-6958): fix llm/icons/swap

* Bugfix/fix eth test (#4076)

* fix: fix Lido/Kiln button analytics not working

* chore: add changeset

* fix: fix eth test lld

* feat(PROTECT-2239): rename recover cta

* fix(deps): update dependency @polkadot/react-identicon to v2.11.3

* feat(recover): restore check seeded [PROTECT-1711]

* feat(recover): add translate for error device already setup [PROTECT-1711]

* feat: fix i18n object title

* Remove .gitignores preventing correct publishing

* changeset

---------

Co-authored-by: Adrien Lacombe <adrien.lacombe@ledger.fr>
Co-authored-by: sarneijim <38540290+sarneijim@users.noreply.github.com>
Co-authored-by: Alexandre Chabrolin <9203826+chabroA@users.noreply.github.com>
Co-authored-by: 0xkvn <44363395+lambertkevin@users.noreply.github.com>
Co-authored-by: Landry Monga <lvndry@protonmail.com>
Co-authored-by: Nabil Bourenane <nabil.bourenane@icloud.com>
Co-authored-by: live-github-bot[bot] <105061298+live-github-bot[bot]@users.noreply.github.com>
Co-authored-by: elbywan <julien.el-baz@ledger.fr>
Co-authored-by: Valentin D. Pinkman <valentin.d.pinkman@hey.com>
Co-authored-by: Maxime Aubanel <sshmaxime@gmail.com>
Co-authored-by: hzheng-ledger <71653044+hzheng-ledger@users.noreply.github.com>
Co-authored-by: Gregor Gilchrist <gregor.gilchrist@ledger.fr>
Co-authored-by: JunichiSugiura <jun.sugiura.jp@gmail.com>
Co-authored-by: lambertkevin <kevin.lambert@ledger.fr>
Co-authored-by: Valentin D. Pinkman <valentin.d.pinkman@icloud.com>
Co-authored-by: Abdurrahman SASTIM <abdurrahman.sastim@ledger.fr>
Co-authored-by: Chuck Ng <cheuk-man.ng@ledger.fr>
Co-authored-by: Beth Swingler <beth.swingler-ext@ledger.fr>
Co-authored-by: Andrei Shtamburg <andrei.shtamburg@ledger.fr>
Co-authored-by: Gabriel Restori Soares <gabriel.soares@ledger.fr>
Co-authored-by: Kieran Allen <kieran.allen@ledger.fr>
Co-authored-by: mdeidda-ledger <marco.deidda@ledger.fr>
Co-authored-by: Kant <quentin.jaccarino@ledger.fr>
Co-authored-by: Stephane Lieumont <stephane.lieumont-ext@ledger.fr>
chabroA added a commit that referenced this pull request Aug 17, 2023
chabroA added a commit that referenced this pull request Aug 17, 2023
chabroA added a commit that referenced this pull request Aug 21, 2023
chabroA added a commit that referenced this pull request Aug 22, 2023
chabroA added a commit that referenced this pull request Aug 22, 2023
chabroA added a commit that referenced this pull request Aug 23, 2023
chabroA added a commit that referenced this pull request Aug 24, 2023
chabroA added a commit that referenced this pull request Aug 24, 2023
chabroA added a commit that referenced this pull request Aug 24, 2023
chabroA added a commit that referenced this pull request Aug 29, 2023
chabroA added a commit that referenced this pull request Aug 29, 2023
chabroA added a commit that referenced this pull request Aug 30, 2023
chabroA added a commit that referenced this pull request Aug 30, 2023
chabroA added a commit that referenced this pull request Aug 31, 2023
chabroA added a commit that referenced this pull request Aug 31, 2023
chabroA added a commit that referenced this pull request Sep 1, 2023
chabroA added a commit that referenced this pull request Sep 4, 2023
chabroA added a commit that referenced this pull request Sep 6, 2023
chabroA added a commit that referenced this pull request Sep 8, 2023
chabroA added a commit that referenced this pull request Sep 11, 2023
chabroA added a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants