fix: removed screenshot swap checks in favour of text check and tidied up services page objects and tests #4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
valpinkman
reviewed
Jul 20, 2023
apps/ledger-live-desktop/src/renderer/drawers/SwapOperationDetails/index.tsx
Outdated
Show resolved
Hide resolved
…d up services page objects and tests
chore: remove pause fix: renamed analytics page property to path chore: removing console logs
ggilchrist-ledger
force-pushed
the
support/deflakify-swap-verify-test
branch
from
4c11a88
to
d63ba40
Compare
valpinkman
approved these changes
Jul 20, 2023
valpinkman
approved these changes
Jul 20, 2023
|
/full-lld-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
NOTE: this PR is primarily to remove the screenshot which was failing due to flaky amounts in the swap verify drawer. We're now just checking the text and that the amount matches up to the first 3 decimals which are consistent as far as we can see. This issue should be fixed as the user could be seeing the wrong amount in the verify screen. Also the functions that generate the formatted amounts should have unit tests given it is a large, complex function and it is used in many places in LLD and LLM.
❓ Context
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.