Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Remove .gitignores preventing correct publishing of evm-tools & domain-service #4090

Merged
2 commits merged into from
Jul 21, 2023

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Jul 20, 2023

πŸ“ Description

This PR is taking example on https://github.com/LedgerHQ/ledger-live/pull/3758/files which resolved the same publishing issue by simply removing .gitgnore files at the lib level.

❓ Context

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes // No breaking change, but patching the previous libs that could be unsable externally

πŸ“Έ Demo

πŸš€ Expectations to reach

Doing a pnpm publish --dry-run inside one the libs directory show that the lib and lib-es directory are not published.
By removing their .gitignore file, this issue is fixed.

@lambertkevin lambertkevin requested a review from a team as a code owner July 20, 2023 14:53
@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023

πŸ¦‹ Changeset detected

Latest commit: e5fffbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
ledger-live-desktop Patch
live-mobile Patch
@ledgerhq/coin-evm Patch
@ledgerhq/evm-tools Patch
@ledgerhq/live-common Patch
@ledgerhq/hw-app-eth Patch
live-common-tools Patch
@ledgerhq/live-cli Patch
@ledgerhq/test-utils Patch
dummy-wallet-app Patch
@ledgerhq/swift-bridge-hw-app-eth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
live-common-tools βœ… Ready (Inspect) Visit Preview Jul 20, 2023 2:53pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 20, 2023 2:53pm
native-ui-storybook ⬜️ Ignored (Inspect) Jul 20, 2023 2:53pm
react-ui-storybook ⬜️ Ignored (Inspect) Jul 20, 2023 2:53pm

@ghost ghost merged commit 7675787 into develop Jul 21, 2023
42 of 49 checks passed
@ghost ghost deleted the support/fix-evm-tools-and-domain-service-publishing branch July 21, 2023 08:50
@ghost ghost restored the support/fix-evm-tools-and-domain-service-publishing branch July 21, 2023 09:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant