Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IconsUI, ReactUI, NativeUI): New icon pack in IconsUI #4091

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

mle-gall
Copy link
Contributor

@mle-gall mle-gall commented Jul 20, 2023

πŸ“ Description

New icon pack in IconsUI.
Renamed old icon pack to Legacy.
Updated old icons imports in LLM.

❓ Context

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screen.Recording.2023-07-20.at.18.36.16.mov

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@mle-gall mle-gall requested a review from a team July 20, 2023 16:39
@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023

πŸ¦‹ Changeset detected

Latest commit: eeab77f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
live-mobile Patch
@ledgerhq/native-ui Patch
@ledgerhq/icons-ui Patch
@ledgerhq/react-ui Patch
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
live-common-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 21, 2023 1:52pm
native-ui-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 21, 2023 1:52pm
react-ui-storybook ❌ Failed (Inspect) Jul 21, 2023 1:52pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 21, 2023 1:52pm

@github-actions github-actions bot added mobile Has changes in LLM ui Has changes in the design system library labels Jul 20, 2023
@mle-gall mle-gall force-pushed the feat/LIVE-8272/UILibNewIcons branch from bbc154f to 6e4ac36 Compare July 20, 2023 18:37
@mle-gall mle-gall requested review from a team as code owners July 20, 2023 18:37
@github-actions github-actions bot added the desktop Has changes in LLD label Jul 20, 2023
@mle-gall mle-gall force-pushed the feat/LIVE-8272/UILibNewIcons branch from 6e4ac36 to b6701fa Compare July 20, 2023 19:43
@mle-gall mle-gall force-pushed the feat/LIVE-8272/UILibNewIcons branch 2 times, most recently from cb24238 to e8d9346 Compare July 21, 2023 13:08
New icon pack in IconsUI. Renamed old icon pack to Legacy. Updated old icons imports in LLM
@sshmaxime sshmaxime self-requested a review July 21, 2023 16:15
@mle-gall mle-gall merged commit 6da418a into develop Jul 21, 2023
42 of 43 checks passed
@mle-gall mle-gall deleted the feat/LIVE-8272/UILibNewIcons branch July 21, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants