Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to roll back bump of usb package to 2.5.1 #4098

Closed
wants to merge 2 commits into from

Conversation

alexandremgo
Copy link
Contributor

@alexandremgo alexandremgo commented Jul 21, 2023

πŸ“ Description

Following issues on LLD 2.63.x and 2.64.x

The bump was made in the following PR: #3625
And it has been tested on Windows though: Jira

❓ Context

  • Impacted projects: ``
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

⚠️ No Changeset found

Latest commit: f8fcdef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
live-common-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 21, 2023 0:09am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 21, 2023 0:09am
native-ui-storybook ⬜️ Ignored (Inspect) Jul 21, 2023 0:09am
react-ui-storybook ⬜️ Ignored (Inspect) Jul 21, 2023 0:09am

@github-actions github-actions bot added the ledgerjs Has changes in the ledgerjs open source libs label Jul 21, 2023
@alexandremgo
Copy link
Contributor Author

The following PR #4104 is the correct fix

@valpinkman valpinkman deleted the bugfix/usb-bump-windows branch September 27, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant