Support/delegate cosmos test #4276
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
github-actions
bot
added
desktop
| @@ -23,6 +24,7 @@ export class AccountPage { | |||
| this.buyButton = page.locator("data-test-id=buy-button"); | |||
| this.sellButton = page.locator("data-test-id=sell-button"); | |||
| this.stakeButton = page.locator("data-test-id=stake-from-account-action-button"); | |||
| this.stakeButtonCosmos = page.locator("data-test-id=stake-button"); | |||
There was a problem hiding this comment.
I think the data test id should be stake-button-cosmos
...-desktop/tests/specs/accounts/delegate.smoke.spec.ts-snapshots/account-page-smoke-darwin.png
Outdated
Show resolved
Hide resolved
|
|
||
| await test.step("start the cosmos delegate flow", async () => { | ||
| await accountPage.startCosmosStakingFlow(); | ||
| await expect.soft(page).toHaveScreenshot(`earn-reward-pre-flow-page.png`); |
There was a problem hiding this comment.
I'd recommend just doing a screenshot of the actual element here, not the full page
apps/ledger-live-desktop/tests/specs/accounts/delegate.smoke.spec.ts
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/tests/specs/accounts/delegate.smoke.spec.ts
Outdated
Show resolved
Hide resolved
|
Looks good! You just need to fix a merge conflict. Also were you not able to do the full flow with the devices? |
mdeidda-ledger
force-pushed
the
support/delegate-cosmos-test
branch
from
637d53e
to
2b9751c
Compare
There was a problem hiding this comment.
Good work !
Couple changes to make:
- You need to change your commit message to pass this check
- There is a conflict on file
apps/ledger-live-desktop/tests/models/Modal.ts
A couple comments on the test strategy :
- for test B2CQA-1552, it doesn't check for "His equivalent is displayed in dollar"
- we limit the testing to max amount and Ledger/Figment providers. We may want to make it expendable.
apps/ledger-live-desktop/tests/specs/accounts/delegate.smoke.spec.ts
Outdated
Show resolved
Hide resolved
mdeidda-ledger
force-pushed
the
support/delegate-cosmos-test
branch
from
2b9751c
to
0fc400c
Compare
mdeidda-ledger
force-pushed
the
support/delegate-cosmos-test
branch
from
0fc400c
to
9a712a7
Compare
|
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
|
👋 it appears this PR was merged with a old state of passing the CI which when rebased/merged with develop seems to have a regression on the screenshot end to end tests of LLD. https://github.com/LedgerHQ/ledger-live/actions/runs/6224717521/job/16893541245 could you take a look asap? |
📝 Description
Added 2 tests scenarios:
scenario 1 : Delegate flow using max amount
scenario 2: Search and select a provider
note: scenario 1 cover that Ledger is the provider by default too.
❓ Context
Impacted projects: LLD
Linked resource(s):
1- https://ledgerhq.atlassian.net/browse/B2CQA-384
2- https://ledgerhq.atlassian.net/browse/B2CQA-1614
3- https://ledgerhq.atlassian.net/browse/B2CQA-1552
4- https://ledgerhq.atlassian.net/browse/B2CQA-1900
✅ Checklist
📸 Demo
Screen.Recording.2023-08-09.at.16.16.10.mov
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.