bugfix: Empty modals when clicking "X" after "Stake" on Earn more rewards tab #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2104e22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
beths-ledger
force-pushed
the
bugfix/LIVE-9008-empty-modals-earn-stake-flow
branch
from
73e5da3
to
d900baa
Compare
kallen-ledger
approved these changes
Aug 25, 2023
mitchellv-ledger
approved these changes
Aug 25, 2023
| @@ -553,6 +548,11 @@ export default function BaseNavigator() { | |||
| options={{ ...TransparentHeaderNavigationOptions, title: "" }} | |||
| component={RedirectToOnboardingRecoverFlowScreen} | |||
| /> | |||
| <Stack.Screen | |||
There was a problem hiding this comment.
Any reason for this move?
There was a problem hiding this comment.
that was just a temp change I made to move them closer together in the base navigator so that i could directly compare them in the file easier, but then i decided just to keep it because they are so heavily related and it seems more useful if they are closer
…igator; use directly in earn nav
beths-ledger
force-pushed
the
bugfix/LIVE-9008-empty-modals-earn-stake-flow
branch
from
d900baa
to
2104e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
❓ Context
ledger-live-mobile✅ Checklist
📸 Demo
Earn dash remains in the background:
In-line with the other screens that use the stake flow from the main navigation or the account pages:
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.