Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/live 8698 Manager API v2 breaking changes adaptations #4896

Merged
merged 22 commits into from
Oct 26, 2023

docs: remove outdated todo

b8806a4
Select commit
Loading
Failed to load commit list.
Merged

Bugfix/live 8698 Manager API v2 breaking changes adaptations #4896

docs: remove outdated todo
b8806a4
Select commit
Loading
Failed to load commit list.
live-github-bot / @PR β€’ Lint Commit Messages β€’ commitlint (conventional) completed Oct 25, 2023 in 1m 49s

❌ Failure

Lint the Pull Request commit messages according to the conventional commits specification.

πŸ”— Workflow run

🚨 Invalid commit message(s)

One or more commits messages are not formatted correctly.
Please rewrite the git history and reword the commit messages in order to fix this issue. πŸ™

πŸ’‘ Tips:

  • Run pnpm commitlint --from <target branch> locally to test your branch.
  • Run pnpm commit will run a prompt that can walk you through writing a correct commit message.
  • If you are not comfortable with git and git rebase --interactive, here is a nice tutorial.

Commitlint output

β§—   input: refacto(common/listapps/v2): reorder without breaking + document
βœ–   type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]

βœ–   found 1 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: refacto(llm/manager): replace prop drilling hell by context
βœ–   type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]

βœ–   found 1 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: fix(llm/InstalledAppsModal): UninstallDependenciesModal not opening
βœ–   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]

βœ–   found 1 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint