Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated dex urls patch #4914

Merged
merged 7 commits into from
Oct 13, 2023

Conversation

cpellizzari-ledger
Copy link
Contributor

@cpellizzari-ledger cpellizzari-ledger commented Oct 2, 2023

πŸ“ Description

Remove deprecated patch on DEX urls retrieved from SWAP backend

❓ Context

  • Impacted projects: LLM, LLD
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-9551

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@live-github-bot
Copy link
Contributor

❌ @cpellizzari-ledger

Unfortunately this PR does not comply with the Contributing Conventions and will be closed automatically.

Feel free to reopen this PR once you have browsed through the guidelines.


Found Issues:

  • the description is missing or you removed or overrode one or more sections of the pull request template
    πŸ’‘ make sure you added comments only inside the template sections - and not above the πŸ“ Description heading

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

⚠️ No Changeset found

Latest commit: c7cdacc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@live-github-bot live-github-bot bot closed this Oct 2, 2023
@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
live-common-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 12, 2023 0:58am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 0:58am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 0:58am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 0:58am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 0:58am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 0:58am

@github-actions github-actions bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common labels Oct 2, 2023
@sarneijim sarneijim merged commit 8f281cd into develop Oct 13, 2023
56 checks passed
@sarneijim sarneijim deleted the bugfix/live-9551-remove-deprecated-patch branch October 13, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants