Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[B2CQA-387] first detox cosmos delegation tests #4974

Merged
merged 3 commits into from
Nov 16, 2023
Merged

[B2CQA-387] first detox cosmos delegation tests #4974

merged 3 commits into from
Nov 16, 2023

Conversation

abdurrahman-ledger
Copy link
Contributor

📝 Description

First Detox Cosmos delegation test. Delegate flow using half amount.
This the LLM equivalent of #4276

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: cf98bb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
live-common-tools ❌ Failed (Inspect) Nov 13, 2023 11:25am
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 11:25am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 11:25am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 11:25am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 11:25am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 11:25am

@github-actions github-actions bot added mobile Has changes in LLM common Has changes in live-common labels Oct 9, 2023
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA_387_Detox_Cosmos_Delegate branch from bbc4b07 to 7d21ac3 Compare October 9, 2023 12:24
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review October 9, 2023 12:30
@abdurrahman-ledger abdurrahman-ledger requested a review from a team as a code owner October 9, 2023 12:30
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA_387_Detox_Cosmos_Delegate branch from 7d21ac3 to 01e2c43 Compare October 12, 2023 14:57
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA_387_Detox_Cosmos_Delegate branch from 01e2c43 to f4d2cfb Compare October 16, 2023 09:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Nov 1, 2023
@github-actions github-actions bot closed this Nov 9, 2023
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA_387_Detox_Cosmos_Delegate branch from f4d2cfb to cf98bb9 Compare November 9, 2023 11:41
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA_387_Detox_Cosmos_Delegate branch from cf98bb9 to 1b80c95 Compare November 10, 2023 09:25
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA_387_Detox_Cosmos_Delegate branch from 1b80c95 to 64fb117 Compare November 10, 2023 15:04
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/B2CQA_387_Detox_Cosmos_Delegate branch from 64fb117 to 5a7d19b Compare November 13, 2023 08:30
@abdurrahman-ledger abdurrahman-ledger requested review from a user and removed request for ggilchrist-ledger November 15, 2023 12:10
ghost
ghost approved these changes Nov 16, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't really assess the test part, but looks good for the code & mock part 👍

.../ledger-live-common/src/families/cosmos/datasets/__snapshots__/dydx.integration.test.ts.snap
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hedi-edelbloute It seems the snapshot for dydx wasn't pushed? Just FYI, it can be pushed now no problem.

@abdurrahman-ledger abdurrahman-ledger merged commit ee4a5a8 into develop Nov 16, 2023
56 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/B2CQA_387_Detox_Cosmos_Delegate branch November 16, 2023 09:29
lvndry pushed a commit that referenced this pull request Nov 16, 2023
@abdurrahman-ledger @lvndry
[B2CQA-387] first detox cosmos delegation tests (#4974)
f660446 
* test: first detox cosmos delegation tests
* fix: fix remaining errors
* chore: update cosmos integration tests snapshots
lvndry pushed a commit that referenced this pull request Nov 16, 2023
@abdurrahman-ledger @lvndry
[B2CQA-387] first detox cosmos delegation tests (#4974)
4291c43 
* test: first detox cosmos delegation tests
* fix: fix remaining errors
* chore: update cosmos integration tests snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gre gre Awaiting requested review from gre

@nabil-brn nabil-brn Awaiting requested review from nabil-brn

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
common Has changes in live-common mobile Has changes in LLM Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abdurrahman-ledger