Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protect-2575): fix black screen at the end of stax flow #5021

Conversation

stephane-lieumont-ledger
Copy link
Contributor

πŸ“ Description

To the last step of onboarding stax, we need to set hasCompletedOnboarding to true

❓ Context

  • Impacted projects: ledger-live-desktop
  • Linked resource(s): protect-2575

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

271027928-7a0a5b55-8b52-48a2-a0b4-6abb5e845d74.mov

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023

πŸ¦‹ Changeset detected

Latest commit: 23c67b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
ledger-live-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 11, 2023 1:14pm
live-common-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 11, 2023 1:14pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 11, 2023 1:14pm
native-ui-storybook ⬜️ Ignored (Inspect) Oct 11, 2023 1:14pm
react-ui-storybook ⬜️ Ignored (Inspect) Oct 11, 2023 1:14pm

@stephane-lieumont-ledger
Copy link
Contributor Author

Implemented on this PR
#5027

@stephane-lieumont-ledger stephane-lieumont-ledger deleted the bugfix/protect-2575-fix-onboarding-stax branch November 13, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant