Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protect-2575): fix black screen at the end of stax flow #5021

Closed
wants to merge 1 commit into from
Closed

fix(protect-2575): fix black screen at the end of stax flow #5021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rich-pianos-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ledger-live-desktop": patch
---

Complete onboarding at the end of stax onboardingflow before recover redirection
14 changes: 11 additions & 3 deletions ...er-live-desktop/src/renderer/components/SyncOnboarding/Manual/SyncOnboardingCompanion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import React, {
import { useHistory } from "react-router-dom";
import { Box, Flex, Text, VerticalTimeline } from "@ledgerhq/react-ui";
import { useTranslation } from "react-i18next";
import { useSelector } from "react-redux";
import { useDispatch, useSelector } from "react-redux";
import { useOnboardingStatePolling } from "@ledgerhq/live-common/onboarding/hooks/useOnboardingStatePolling";
import { getDeviceModel } from "@ledgerhq/devices";
import { DeviceModelInfo, SeedPhraseType } from "@ledgerhq/types-live";
Expand All @@ -29,11 +29,12 @@ import { getOnboardingStatePolling } from "@ledgerhq/live-common/hw/getOnboardin
import ContinueOnDeviceWithAnim from "./ContinueOnDeviceWithAnim";
import { RecoverState } from "~/renderer/screens/recover/Player";
import TrackPage from "~/renderer/analytics/TrackPage";
import { trackPage } from "~/renderer/analytics/segment";
import { track, trackPage } from "~/renderer/analytics/segment";
import { Device } from "@ledgerhq/live-common/hw/actions/types";
import { setDrawer } from "~/renderer/drawers/Provider";
import LockedDeviceDrawer, { Props as LockedDeviceDrawerProps } from "./LockedDeviceDrawer";
import { LockedDeviceError } from "@ledgerhq/errors";
import { saveSettings } from "~/renderer/actions/settings";

const READY_REDIRECT_DELAY_MS = 2500;
const POLLING_PERIOD_MS = 1000;
Expand Down Expand Up @@ -100,6 +101,7 @@ const SyncOnboardingCompanion: React.FC<SyncOnboardingCompanionProps> = ({
notifySyncOnboardingShouldReset,
}) => {
const { t } = useTranslation();
const dispatch = useDispatch();
const history = useHistory<RecoverState>();
const [stepKey, setStepKey] = useState<StepKey>(StepKey.Paired);
const [shouldRestoreApps, setShouldRestoreApps] = useState<boolean>(false);
Expand Down Expand Up @@ -456,13 +458,19 @@ const SyncOnboardingCompanion: React.FC<SyncOnboardingCompanionProps> = ({
useEffect(() => {
if (seedPathStatus === "recover_seed" && postOnboardingPath) {
const [pathname, search] = postOnboardingPath.split("?");
dispatch(
saveSettings({
hasCompletedOnboarding: true,
}),
);
track("Onboarding - End");
history.push({
pathname,
search: search ? `?${search}` : undefined,
state: { fromOnboarding: true },
});
}
}, [history, postOnboardingPath, seedPathStatus]);
}, [dispatch, history, postOnboardingPath, seedPathStatus]);

return (
<Flex width="100%" height="100%" flexDirection="column" justifyContent="flex-start">
Expand Down
Loading