fix(LIVE-9486): add specific featureFlags deeplinks tutorial #5027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 843834a The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
github-actions
bot
added
desktop
stephane-lieumont-ledger
force-pushed
the
bugfix/deeplink-redirection-tracking-lld
branch
from
7c81fa4
to
2d776a8
Compare
Justkant
reviewed
Oct 20, 2023
Comment on lines
139
to
141
| const search = `?${page ? `redirectTo=${page}` : ""}${page && source ? "&" : ""}${ | ||
| source ? `source=${source}` : "" | ||
| }`; |
There was a problem hiding this comment.
You might want to use URLSearchParams and call .toString() on it instead of constructing by hand the different variant
There was a problem hiding this comment.
Comment on lines
577
to
580
| } else if (useCase === UseCase.recoveryPhrase && postOnboardingPath) { | ||
| history.push(postOnboardingPath); | ||
| } else if (useCase === UseCase.connectDevice && devicePairingPath) { | ||
| history.push(devicePairingPath); |
There was a problem hiding this comment.
Was that added to move to different "route" if you end the onboarding in different screens ?
There was a problem hiding this comment.
Yes it's done on liveApp
The links are update on featureflags protectServiceDesktop (dev).
We need to wait next release to update FF staging and prod
There is all routes params for deeplinks_clicked events
We need to send this with the LiveApp to have the good UserID of Recover
…:LedgerHQ/ledger-live into bugfix/deeplink-redirection-tracking-lld
…:LedgerHQ/ledger-live into bugfix/deeplink-redirection-tracking-lld
Justkant
requested changes
Oct 25, 2023
Comment on lines
156
to
164
| const [basicUri] = modelUri ? modelUri.split("?") : []; | ||
| const uri = new URL(basicUri); | ||
|
|
||
| if (page) uri.searchParams.append("redirectTo", page); | ||
| if (source) uri.searchParams.append("source", source); | ||
| if (source && deeplinkCampaign) { | ||
| uri.searchParams.append("ajs_recover_source", source); | ||
| uri.searchParams.append("ajs_recover_campaign", deeplinkCampaign); | ||
| } |
There was a problem hiding this comment.
Not sure about the cost of creating an URL and appending to it but I would memo that part
Suggested change
| const [basicUri] = modelUri ? modelUri.split("?") : []; | |
| const uri = new URL(basicUri); | |
| if (page) uri.searchParams.append("redirectTo", page); | |
| if (source) uri.searchParams.append("source", source); | |
| if (source && deeplinkCampaign) { | |
| uri.searchParams.append("ajs_recover_source", source); | |
| uri.searchParams.append("ajs_recover_campaign", deeplinkCampaign); | |
| } | |
| const uri = useMemo(() => { | |
| const [basicUri] = modelUri ? modelUri.split("?") : []; | |
| const uri = new URL(basicUri); | |
| if (page) uri.searchParams.append("redirectTo", page); | |
| if (source) uri.searchParams.append("source", source); | |
| if (source && deeplinkCampaign) { | |
| uri.searchParams.append("ajs_recover_source", source); | |
| uri.searchParams.append("ajs_recover_campaign", deeplinkCampaign); | |
| } | |
| return uri; | |
| }, [deeplinkCampaign, modelUri, page, source]); |
There was a problem hiding this comment.
Justkant
approved these changes
Oct 25, 2023
stephane-lieumont-ledger
removed the request for review
from cgrellard-ledger
stephane-lieumont-ledger
deleted the
bugfix/deeplink-redirection-tracking-lld
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
❓ Context
ledger-live-desktop,live-common,types-live✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.