Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add missing types for the wallet-api CustomLogger #5155

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Justkant
Copy link
Contributor

πŸ“ Description

Just adding some missing types in the CustomLogger module to improve safety

❓ Context

  • Impacted projects: ``
  • Linked resource(s): []

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@Justkant Justkant requested a review from a team October 20, 2023 12:45
@Justkant Justkant self-assigned this Oct 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

πŸ¦‹ Changeset detected

Latest commit: 3ce4f6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@ledgerhq/live-common Patch
@ledgerhq/live-cli Patch
ledger-live-desktop Patch
live-mobile Patch
web-tools Patch
@ledgerhq/test-utils Patch
dummy-wallet-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 25, 2023 7:50am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 7:50am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 7:50am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 7:50am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 7:50am

@live-github-bot live-github-bot bot added the common Has changes in live-common label Oct 20, 2023
Copy link
Contributor

@ComradeAERGO ComradeAERGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Justkant Justkant merged commit 954b230 into develop Oct 25, 2023
56 checks passed
@Justkant Justkant deleted the support/custom-add-types branch October 25, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants