[LL] - [LIVE-9593] - Fix networks not displaying for some tokens on receive and other screens #5184
Conversation
🦋 Changeset detectedLatest commit: b4b5bd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
Can you add a changeset ? :) |
| @@ -11,7 +11,7 @@ const groupCurrenciesByProvider = ( | |||
| } | |||
| const assetsByProviderId: Record<string, CurrenciesByProviderId> = {}; | |||
| for (const ledgerCurrency of currenciesSupported) { | |||
| const asset = assetsByLedgerId[ledgerCurrency.id]; | |||
| const asset = assetsByLedgerId[ledgerCurrency.id.toLowerCase()]; | |||
| if (asset) { | |||
| if (!assetsByProviderId[asset.providerId]) { | |||
| assetsByProviderId[asset.providerId] = { | |||
There was a problem hiding this comment.
even there maybe also?
There was a problem hiding this comment.
@KVNLS @mcayuelas-ledger @cgrellard-ledger things coming out of getMappedAssets() are properly formatted (i.e lowercased) and coming from our APIs. It's unnecessary to lowercase it, we could do it for the sake of it, but I think it would be a stretch. That being said I can do it if one of you think it's worth it, let me know
Besides that I'm currently talking with the backend team to unify and agree on specific types of string for such things, to be continued ...
There was a problem hiding this comment.
At least we will be resilient for changes, if they decide to upperCase tomorrow.
📝 Description
As of today, there is a discrepancy between the
idreturned by the APIs and the one we have inledgerjs. The discrepancy comes from the fact that inledgerjslibrary currencies id are not lowercase formatted. While waiting for that to be discussed this is a small fix to quick fix the current issue.❓ Context
LL✅ Checklist
📸 Demo
Before:
Screen.Recording.2023-10-24.at.17.14.09.mov
After:
Screen.Recording.2023-10-24.at.17.11.07.mov
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.