Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LL] - [LIVE-9593] - Fix networks not displaying for some tokens on receive and other screens #5184

Merged
merged 3 commits into from
Oct 25, 2023
Merged

[LL] - [LIVE-9593] - Fix networks not displaying for some tokens on receive and other screens #5184

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4c3278
Fix ledgerCurrency id to lowercase
sshmaxime Oct 24, 2023
2ec5360
Add changeset
sshmaxime Oct 25, 2023
b4b5bd3
Add lowercase extra safety
sshmaxime Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/ledger-live-common/src/deposit/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const groupCurrenciesByProvider = (
}
const assetsByProviderId: Record<string, CurrenciesByProviderId> = {};
for (const ledgerCurrency of currenciesSupported) {
const asset = assetsByLedgerId[ledgerCurrency.id];
const asset = assetsByLedgerId[ledgerCurrency.id.toLowerCase()];
if (asset) {
if (!assetsByProviderId[asset.providerId]) {
assetsByProviderId[asset.providerId] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even there maybe also?

Copy link
Contributor Author

@sshmaxime sshmaxime Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KVNLS @mcayuelas-ledger @cgrellard-ledger things coming out of getMappedAssets() are properly formatted (i.e lowercased) and coming from our APIs. It's unnecessary to lowercase it, we could do it for the sake of it, but I think it would be a stretch. That being said I can do it if one of you think it's worth it, let me know

Besides that I'm currently talking with the backend team to unify and agree on specific types of string for such things, to be continued ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least we will be resilient for changes, if they decide to upperCase tomorrow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @KVNLS

Expand Down
Loading