Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› [BUGFIX] : Fix Placeholder for language in changeLanguagePrompt #5200

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Oct 25, 2023

πŸ“ Description

Placeholder text when changing device language from Settings in FR and Spanish

❓ Context

  • Impacted projects: LLD
  • Linked resource(s): LIVE-9960

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screen.Recording.2023-10-25.at.15.04.19.mov

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

πŸ¦‹ Changeset detected

Latest commit: e72ed60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 2:13pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 2:13pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 2:13pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 2:13pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 2:13pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 25, 2023
@mcayuelas-ledger mcayuelas-ledger requested review from KVNLS and a team October 25, 2023 13:14
@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented Oct 25, 2023

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
βœ… - generate-screenshots-mac
βœ… - generate-screenshots-windows
βœ… - generate-screenshots-linux

@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Oct 25, 2023
@sshmaxime sshmaxime merged commit 63657e5 into develop Oct 26, 2023
43 of 70 checks passed
@sshmaxime sshmaxime deleted the bugfix/placeholder-text-when-changing-device-language-from-Settings branch October 26, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD screenshots Screenshots have been updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants