Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert extract json #5203

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix: revert extract json #5203

merged 1 commit into from
Oct 25, 2023

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 25, 2023

πŸ“ Description

Revert extract json

❓ Context

  • Impacted projects: ``
  • Linked resource(s): []

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@KVNLS KVNLS self-assigned this Oct 25, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

⚠️ No Changeset found

Latest commit: 6a65bcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 25, 2023 3:12pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 25, 2023 3:12pm
native-ui-storybook ⬜️ Ignored (Inspect) Oct 25, 2023 3:12pm
react-ui-storybook ⬜️ Ignored (Inspect) Oct 25, 2023 3:12pm
web-tools ⬜️ Ignored (Inspect) Oct 25, 2023 3:12pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 25, 2023
@KVNLS KVNLS marked this pull request as ready for review October 25, 2023 15:35
@KVNLS KVNLS requested review from a team and valpinkman October 25, 2023 15:35
@valpinkman valpinkman merged commit 43b868b into develop Oct 25, 2023
29 of 31 checks passed
@valpinkman valpinkman deleted the support/revert-extract-json branch October 25, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants