Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[support] Replace hardcoded countervalues URL with value from env var #5650

Merged
7 commits merged into from
Jan 5, 2024

Conversation

ghost
Copy link

@ghost ghost commented Dec 5, 2023

📝 Description

For some bad reason, the URL of the countervalues backend was hardcoded in a couple places in the code.
This PR just replaces these with the value from the env var.

Additionally it makes Hedera use the countervalue API in Live instead of directly hitting the countervalue backend.

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes: Hedera uses the countervalue API

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@ghost ghost requested a review from gre December 5, 2023 11:30
@ghost ghost self-requested a review as a code owner December 5, 2023 11:30
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 1:47pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 1:47pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 1:47pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 1:47pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 1:47pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Dec 5, 2023
@github-actions github-actions bot assigned ghost Dec 5, 2023
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to make getEnv called lazily, otherwise all is good

libs/ledger-live-common/src/families/hedera/utils.ts Outdated Show resolved Hide resolved
chabroA
chabroA previously approved these changes Dec 18, 2023
@ghost ghost requested review from a team as code owners December 20, 2023 14:29
@ghost
Copy link
Author

ghost commented Dec 20, 2023

@gre Ready for review, let me know if this is OK regarding cvs API.

@ghost ghost deleted a comment from github-actions bot Jan 2, 2024
@ghost ghost merged commit e4c8b3a into develop Jan 5, 2024
55 of 56 checks passed
@ghost ghost deleted the support/countervalues-hardcoded-urls branch January 5, 2024 17:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants