-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[support] Replace hardcoded countervalues URL with value from env var #5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from gre
December 5, 2023 11:30
ghost
self-requested a review
as a code owner
December 5, 2023 11:30
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
live-github-bot
bot
added
desktop
Has changes in LLD
common
Has changes in live-common
labels
Dec 5, 2023
gre
suggested changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to make getEnv called lazily, otherwise all is good
ghost
requested a review
from gre
December 5, 2023 13:43
chabroA
previously approved these changes
Dec 18, 2023
@gre Ready for review, let me know if this is OK regarding cvs API. |
gre
approved these changes
Dec 21, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
For some bad reason, the URL of the countervalues backend was hardcoded in a couple places in the code.
This PR just replaces these with the value from the env var.
Additionally it makes Hedera use the countervalue API in Live instead of directly hitting the countervalue backend.
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changeset
was attached.🧐 Checklist for the PR Reviewers