Feat/safer solana #5797

hedi-edelbloute · 2023-12-22T09:15:20Z

📝 Description

PR #5228 on our Repo for QA

See other PR for full description

❓ Context

JIRA or GitHub link: https://ledgerhq.atlassian.net/browse/LIVE-8292

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

npx changeset was attached.
Covered by automatic tests.
[ ] Impact of the changes:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

… and use max

… to extract max spendable balance to be calculated once on the upper context

…hdrawing

…o feat/safer-solana

vercel · 2023-12-22T09:15:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 22, 2023 9:17am

4 Ignored Deployments

Name	Status	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Dec 22, 2023 9:17am
ledger-live-github-bot	⬜️ Ignored (Inspect)	Dec 22, 2023 9:17am
native-ui-storybook	⬜️ Ignored (Inspect)	Dec 22, 2023 9:17am
react-ui-storybook	⬜️ Ignored (Inspect)	Dec 22, 2023 9:17am

github-actions · 2023-12-22T09:43:14Z

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 5s

1 critical spec errors

Spec Solana failed!

Error: scan accounts timeout for currency Solana

Details of the 0 mutations

Spec Solana (failed)

Details of the 8 uncovered mutations

Spec Solana (8)

Transfer ~50%:
Transfer Max:
Delegate:
Deactivate Activating Delegation:
Deactivate Active Delegation:
Reactivate Deactivating Delegation:
Activate Inactive Delegation:
Withdraw Delegation:

Portfolio ($0.00) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Solana (0)	0 ops , 🤷‍♂️	❌	``

Performance ⏲ 10min 5s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	193ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A
Solana (0)	193ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A

github-actions · 2023-12-22T14:00:03Z

[Bot] Testing with 'Oxygen' 💰 1 miss funds ($0.00) ⏲ 31.8s

⚠️ 1 spec hints

Spec Solana:
- There are not enough accounts (1) to cover all mutations (8).
  Please increase the account target to at least 9 accounts

Details of the 0 mutations

Spec Solana (failed)

Spec Solana found 1 Solana accounts (preload: 142ms). Will use Solana 1.2.0 on nanoS 2.1.0
Solana 1 cross: 0 SOL (0ops) (5aSiryY55P7fcasAzSWGf2bGDr1SKokiZntRNpnTDnVC on 44'/501'/0') solanaSub#0 js:2:solana:5aSiryY55P7fcasAzSWGf2bGDr1SKokiZntRNpnTDnVC:solanaSub

This SEED does not have Solana. Please send funds to 5aSiryY55P7fcasAzSWGf2bGDr1SKokiZntRNpnTDnVC

Details of the 8 uncovered mutations

Spec Solana (8)

Transfer ~50%:
Transfer Max:
Delegate:
Deactivate Activating Delegation:
Deactivate Active Delegation:
Reactivate Deactivating Delegation:
Activate Inactive Delegation:
Withdraw Delegation:

Portfolio ($0.00) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Solana (1)	0 ops , 0 SOL ($0.00)	❌	`5aSiryY55P7fcasAzSWGf2bGDr1SKokiZntRNpnTDnVC`

Solana 1 cross: 0 SOL (0ops) (5aSiryY55P7fcasAzSWGf2bGDr1SKokiZntRNpnTDnVC on 44'/501'/0') solanaSub#0 js:2:solana:5aSiryY55P7fcasAzSWGf2bGDr1SKokiZntRNpnTDnVC:solanaSub

Performance ⏲ 31.8s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	142ms	19s	N/A	N/A	N/A	N/A	N/A	N/A
Solana (0)	142ms	19s	N/A	N/A	N/A	N/A	N/A	N/A

github-actions · 2023-12-22T16:15:58Z

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 4s

1 critical spec errors

Spec Solana failed!

Error: scan accounts timeout for currency Solana

Details of the 0 mutations

Spec Solana (failed)

Details of the 8 uncovered mutations

Spec Solana (8)

Transfer ~50%:
Transfer Max:
Delegate:
Deactivate Activating Delegation:
Deactivate Active Delegation:
Reactivate Deactivating Delegation:
Activate Inactive Delegation:
Withdraw Delegation:

Portfolio ($0.00) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Solana (0)	0 ops , 🤷‍♂️	❌	``

Performance ⏲ 10min 4s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	132ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A
Solana (0)	132ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A

github-actions · 2023-12-26T11:39:36Z

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 4s

1 critical spec errors

Spec Solana failed!

Error: scan accounts timeout for currency Solana

Details of the 0 mutations

Spec Solana (failed)

Details of the 8 uncovered mutations

Spec Solana (8)

Transfer ~50%:
Transfer Max:
Delegate:
Deactivate Activating Delegation:
Deactivate Active Delegation:
Reactivate Deactivating Delegation:
Activate Inactive Delegation:
Withdraw Delegation:

Portfolio ($0.00) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Solana (0)	0 ops , 🤷‍♂️	❌	``

Performance ⏲ 10min 4s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	142ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A
Solana (0)	142ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A

github-actions · 2023-12-26T13:26:09Z

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 3s

1 critical spec errors

Spec Solana failed!

Error: scan accounts timeout for currency Solana

Details of the 0 mutations

Spec Solana (failed)

Details of the 8 uncovered mutations

Spec Solana (8)

Transfer ~50%:
Transfer Max:
Delegate:
Deactivate Activating Delegation:
Deactivate Active Delegation:
Reactivate Deactivating Delegation:
Activate Inactive Delegation:
Withdraw Delegation:

Portfolio ($0.00) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Solana (0)	0 ops , 🤷‍♂️	❌	``

Performance ⏲ 10min 3s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	156ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A
Solana (0)	156ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A

github-actions · 2023-12-28T09:57:47Z

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 4s

1 critical spec errors

Spec Solana failed!

Error: scan accounts timeout for currency Solana

Details of the 0 mutations

Spec Solana (failed)

Details of the 8 uncovered mutations

Spec Solana (8)

Transfer ~50%:
Transfer Max:
Delegate:
Deactivate Activating Delegation:
Deactivate Active Delegation:
Reactivate Deactivating Delegation:
Activate Inactive Delegation:
Withdraw Delegation:

Portfolio ($0.00) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Solana (0)	0 ops , 🤷‍♂️	❌	``

Performance ⏲ 10min 4s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	134ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A
Solana (0)	134ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A

github-actions · 2024-01-13T04:24:57Z

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

sponomarev and others added 17 commits December 20, 2023 13:15

feat(solana): add reserve warning to the staking process

24e187c

fix(solana): maximum staking amount discrepancy between max available…

d84aec8

… and use max

chore: add changeset

e0bdc5d

chore(solana): refactor deriveCommandDescriptor and its subcommands…

b725ed6

… to extract max spendable balance to be calculated once on the upper context

fix(solana): maximum available balance for staking

e2f0227

feat(solana): make LLM behave similar to LLD on Solana staking

3f9ea81

feat(solana): reserve future undelegate and withdrawal fees on staking

e21058c

fix(solana): take into account space rent for spendable balance

f7a023b

chore(solana): refactor max spendable and fee calculation

6ccac2e

chore(solana): refactor fee estimation to uncouple with Account type

f907da1

feat(solana): consider stake reserve in spendable balance

15eb435

chore(solana): prepare transaction imports cleanup

312716b

feat(solana): add unstake reserve to the account

bf876e8

feat(solana): allow spending unstake reserve for undelegating and wit…

2a51f30

…hdrawing

fix: typecheck offence

49b924d

fix(solana): SolanaResourcesRaw serialization

a9b409f

Merge remote-tracking branch 'hoodieshq/feat/solana-safe-staking' int…

e1fb9bf

…o feat/safer-solana

github-actions bot assigned hedi-edelbloute Dec 22, 2023

live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common translations Translation files have been touched labels Dec 22, 2023

hedi-edelbloute mentioned this pull request Dec 22, 2023

Safer Solana staking #5228

Merged

3 tasks

vercel bot deployed to Preview – web-tools December 22, 2023 09:17 View deployment

github-actions bot added the Stale label Jan 13, 2024

github-actions bot closed this Jan 27, 2024

KVNLS deleted the feat/safer-solana branch April 2, 2024 15:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/safer solana #5797

Feat/safer solana #5797

hedi-edelbloute commented Dec 22, 2023

vercel bot commented Dec 22, 2023 •

edited

Loading

github-actions bot commented Dec 22, 2023

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Dec 22, 2023

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Dec 22, 2023

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Dec 26, 2023

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Dec 26, 2023

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Dec 28, 2023

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Jan 13, 2024

Feat/safer solana #5797

Feat/safer solana #5797

Conversation

hedi-edelbloute commented Dec 22, 2023

📝 Description

❓ Context

✅ Checklist

[ ] Impact of the changes:

🧐 Checklist for the PR Reviewers

vercel bot commented Dec 22, 2023 • edited Loading

github-actions bot commented Dec 22, 2023

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 5s

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Dec 22, 2023

[Bot] Testing with 'Oxygen' 💰 1 miss funds ($0.00) ⏲ 31.8s

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Dec 22, 2023

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 4s

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Dec 26, 2023

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 4s

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Dec 26, 2023

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 3s

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Dec 28, 2023

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 10min 4s

Spec Solana (failed)

Spec Solana (8)

github-actions bot commented Jan 13, 2024

vercel bot commented Dec 22, 2023 •

edited

Loading