Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[support] Change vechain's bot spec to use NanoS+ app instead of NanoX #5822

Merged
1 commit merged into from
Jan 2, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 2, 2024

📝 Description

For some reason the bot spec for Vechain has been set to use the NanoX app.
While this works, it makes it mandatory to checkout NanoX apps for every single run of the bot in the CI.
Vechain is the only spec using the NanoX app, so this PR makes it use the NanoS+ app instead, which is the reference device that all of our integrations should be gradually migrated to.

❓ Context

  • JIRA or GitHub link: N/A

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • [ ] Impact of the changes:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview Jan 2, 2024 3:43pm
4 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jan 2, 2024 3:43pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jan 2, 2024 3:43pm
native-ui-storybook ⬜️ Ignored (Inspect) Jan 2, 2024 3:43pm
react-ui-storybook ⬜️ Ignored (Inspect) Jan 2, 2024 3:43pm

@github-actions github-actions bot assigned ghost Jan 2, 2024
@live-github-bot live-github-bot bot added the common Has changes in live-common label Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

[Bot] Testing with 'Nitrogen' ❌ 1 txs 💰 1 miss funds ($0.62) ⏲ 16.7s

❌ 1 specs have problems: VeChain VTHO
💰 1 specs may miss funds: VeChain VET

What is the bot and how does it work? Everything is documented here!

❌ 1 mutation errors
necessary accounts resynced in 0.21ms
▬ VeChain 1.1.1 on nanoSP 1.1.0
→ FROM Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain 0 VET spendable. 
  TokenAccount Vethor: 54.3706899375 VTHO (2 ops) (! sum of ops 55 VTHO)
max spendable ~0
★ using mutation 'move all VTHO'
→ TO Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain
✔️ transaction SEND MAX TO 0x6fc5998724338CDe55Bba798273FAdcDE79c5074
STATUS (1652ms)
  amount: 53.7042299375 VTHO
  estimated fees: 0.66646 VET
  total spent: 54.3706899375 VTHO
errors: 
errors: 
⚠️ VechainAppPleaseEnableContractDataAndMultiClause: Please enable contract data in Vechain app settings
(totally spent 1674ms – ends at 2024-01-02T15:56:34.038Z)
⚠️ 2 spec hints
  • Spec VeChain VTHO:
    • mutations should define a testDestination(): move all VTHO
  • Spec VeChain VET:
    • No mutation were found possible. Yet there are funds in the accounts, please investigate.
Details of the 1 mutations

Spec VeChain VTHO (3)

Spec VeChain VTHO found 3 Vechain accounts. Will use VeChain 1.1.1 on nanoSP 1.1.0
Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain
Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain
necessary accounts resynced in 0.21ms
▬ VeChain 1.1.1 on nanoSP 1.1.0
→ FROM Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain 0 VET spendable. 
  TokenAccount Vethor: 54.3706899375 VTHO (2 ops) (! sum of ops 55 VTHO)
max spendable ~0
★ using mutation 'move all VTHO'
→ TO Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain
✔️ transaction SEND MAX TO 0x6fc5998724338CDe55Bba798273FAdcDE79c5074
STATUS (1652ms)
  amount: 53.7042299375 VTHO
  estimated fees: 0.66646 VET
  total spent: 54.3706899375 VTHO
errors: 
errors: 
⚠️ VechainAppPleaseEnableContractDataAndMultiClause: Please enable contract data in Vechain app settings
(totally spent 1674ms – ends at 2024-01-02T15:56:34.042Z)

Spec VeChain VET (3)

Spec VeChain VET found 3 Vechain accounts. Will use VeChain 1.1.1 on nanoSP 1.1.0
Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain
Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain

Details of the 3 uncovered mutations

Spec VeChain VTHO (1)

  • move ~50% VTHO: Vechain: VTHO balance is not enough (2)

Spec VeChain VET (2)

  • move ~50% VET: Vechain: VET balance is empty (2), Vechain: VTHO balance is not enough (1)
  • move all VET: Vechain: VET balance is empty (2), Vechain: VTHO balance is not enough (1)
Portfolio ($0.62) – Details of the 2 currencies
Spec (accounts) State Remaining Runs (est) funds?
VeChain VTHO (3) 7 ops , 5 VET ($0.31) ⚠️ 12 0xc4B17901FECf86932c3bb296BB00E7c6816Fd416
VeChain VET (3) 7 ops , 5 VET ($0.31) ⚠️ 12 0xc4B17901FECf86932c3bb296BB00E7c6816Fd416
Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain
Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain
Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain
Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain
Performance ⏲ 16.7s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 1.66ms 14.8s 1.76ms 1652ms N/A N/A N/A N/A
VeChain VTHO (2) 1.42ms 7.4s 0.87ms 1652ms N/A N/A N/A N/A
VeChain VET (2) 0.24ms 7.4s 0.89ms N/A N/A N/A N/A N/A

What is the bot and how does it work? Everything is documented here!

@ghost ghost marked this pull request as ready for review January 2, 2024 18:07
@ghost ghost self-requested a review as a code owner January 2, 2024 18:07
@ghost
Copy link
Author

ghost commented Jan 2, 2024

(bot failure already present on develop)

@ghost ghost merged commit 94d229e into develop Jan 2, 2024
56 of 58 checks passed
@ghost ghost deleted the support/vechain-bot-nanosp branch January 2, 2024 18:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants