-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[support] Change vechain's bot spec to use NanoS+ app instead of NanoX #5822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
[Bot] Testing with 'Nitrogen' ❌ 1 txs 💰 1 miss funds ($0.62) ⏲ 16.7s
❌ 1 mutation errors
|
Spec (accounts) | State | Remaining Runs (est) | funds? |
---|---|---|---|
VeChain VTHO (3) | 7 ops , 5 VET ($0.31) | 0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 |
|
VeChain VET (3) | 7 ops , 5 VET ($0.31) | 0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 |
Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain
Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain
Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain
Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain
Performance ⏲ 16.7s
Time spent for each spec: (total across mutations)
Spec (accounts) | preload | scan | re-sync | tx status | sign op | broadcast | test | destination test |
---|---|---|---|---|---|---|---|---|
TOTAL | 1.66ms | 14.8s | 1.76ms | 1652ms | N/A | N/A | N/A | N/A |
VeChain VTHO (2) | 1.42ms | 7.4s | 0.87ms | 1652ms | N/A | N/A | N/A | N/A |
VeChain VET (2) | 0.24ms | 7.4s | 0.89ms | N/A | N/A | N/A | N/A | N/A |
What is the bot and how does it work? Everything is documented here!
ghost
marked this pull request as ready for review
January 2, 2024 18:07
ghost
self-requested a review
as a code owner
January 2, 2024 18:07
hedi-edelbloute
approved these changes
Jan 2, 2024
(bot failure already present on develop) |
ghost
deleted the
support/vechain-bot-nanosp
branch
January 2, 2024 18:09
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
For some reason the bot spec for Vechain has been set to use the NanoX app.
While this works, it makes it mandatory to checkout NanoX apps for every single run of the bot in the CI.
Vechain is the only spec using the NanoX app, so this PR makes it use the NanoS+ app instead, which is the reference device that all of our integrations should be gradually migrated to.
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changeset
was attached.[ ] Impact of the changes:
🧐 Checklist for the PR Reviewers