chore: update react-native-webview [LIVE-12644] #7135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/react-native-webview@11.26.1 |
cgrellard-ledger
previously approved these changes
Jun 19, 2024
Justkant
force-pushed
the
support/LIVE-12644
branch
from
bebc796
to
e985f4a
Compare
cgrellard-ledger
approved these changes
Jun 19, 2024
RamyEB
approved these changes
Jun 19, 2024
| if (supported) { | ||
| Linking.openURL(targetUrl); | ||
| } else { | ||
| console.error(`Don't know how to open URI: ${targetUrl}`); |
There was a problem hiding this comment.
Might be a better error message ?
onOpenWindow | URL_UNSUPPORTED : Unable to check if the URL can be opened.
There was a problem hiding this comment.
URL and URI is not the same thing, here we are talking about an URI
I can update this to something like URI not supported: ${targetUrl} because we are able to check if the URI can be opened but it's just not supported or able to be opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Updates the react-native-webview dependency to the latest version
Keeps all previously patched behaviours:
target="_blank"links on iOS in the default browserallowInsecureHttpsfor recoverKnown bug:
Screen.Recording.2024-06-18.at.17.33.51.mov
Screen.Recording.2024-06-18.at.17.34.56.mov
❓ Context
🧐 Checklist for the PR Reviewers